Skip to content

-support system locale in lifecycle hit to analytics#96

Merged
kevinlind merged 1 commit intoadobe:dev-v4.0.0from
sbenedicadb:dev-v3.2.1
Jun 5, 2023
Merged

-support system locale in lifecycle hit to analytics#96
kevinlind merged 1 commit intoadobe:dev-v4.0.0from
sbenedicadb:dev-v3.2.1

Conversation

@sbenedicadb
Copy link
Copy Markdown
Member

@sbenedicadb sbenedicadb commented May 12, 2023 •
edited by emdobrin
Loading

Description

in alignment with adobe/aepsdk-core-ios#935 - this pr grabs the new value from lifecycle and adds it to the outgoing lifecycle hit for analytics

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented May 12, 2023

Codecov Report

Merging #96 (ea3a5ae) into dev-v3.2.1 (4a6d359) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           dev-v3.2.1      #96   +/-   ##
===========================================
  Coverage       86.86%   86.86%           
===========================================
  Files              14       14           
  Lines            1119     1119           
===========================================
  Hits              972      972           
  Misses            147      147

@sbenedicadb sbenedicadb requested a review from addb May 15, 2023 15:29
@addb addb requested a review from kevinlind May 16, 2023 03:07
@addb addb changed the base branch from dev-v3.2.1 to dev-v4.0.0 June 2, 2023 23:13
@kevinlind kevinlind merged commit 6f403a2 into adobe:dev-v4.0.0 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlind kevinlind kevinlind approved these changes

@addb addb Awaiting requested review from addb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbenedicadb @kevinlind