Merged
Conversation
kevinlind
approved these changes
May 26, 2023
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Looks good. Left one small comment to update the documentation on the LifecycleUtils formatting function.
|
|
||
| /// Return a string for the given 'locale' identifier. | ||
| /// Returns a BCP formatted locale from the calling locale String. | ||
| /// Uses the format "`Locale.languageCode`-`Locale.regionCode`". |
Contributor
There was a problem hiding this comment.
Can you update this comment to clarify?
Uses
Locale.identifier(.bcp47)for iOS 16+, otherwise uses format "Locale.languageCode-Locale.regionCode"
kevinlind
approved these changes
May 26, 2023
praveek
approved these changes
May 30, 2023
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: