Skip to content

Bug 987597: Send an caller identifier when obtaining a call-url#6

Merged
Standard8 merged 1 commit intoloop-ui-initialfrom
bug-987597-call-url-with-identifier
Mar 26, 2014
Merged

Bug 987597: Send an caller identifier when obtaining a call-url#6
Standard8 merged 1 commit intoloop-ui-initialfrom
bug-987597-call-url-with-identifier

Conversation

@tOkeshu
Copy link
Collaborator

@tOkeshu tOkeshu commented Mar 25, 2014

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to pass the simplepushURL here, I think?

@Standard8
Copy link
Collaborator

I think there's two more things we need to address:

  1. We probably shouldn't enable the get button, until some text has been entered.
  2. We need to handle what renew does - there's no opportunity to change/set the name there at the moment, so maybe we need to make the renew button a 'clear', and then allow entering of a new id etc.

@tOkeshu
Copy link
Collaborator Author

tOkeshu commented Mar 26, 2014

@Standard8 do we really need a renew button right now? The UX seems to not be clear enough here.
I would suggest that we replace the renew button by something like « Create a new URL », or maybe keep the first view displayed once we get the URL.

@Standard8
Copy link
Collaborator

I think we should have a clear button (or create new url), so that people can generate a new URL, but renew isn't right IMO.

@tOkeshu
Copy link
Collaborator Author

tOkeshu commented Mar 26, 2014

For the sake of clarify, we want a button to go back to the previous view instead of the renew button.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now what's up with the extra space before the equals ;-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I take that comment back, it wasn't clear it was aligning with the = on the line above.

@Standard8
Copy link
Collaborator

Basic outline of changes looks good, either myself or @dmose will need to give this a test & slightly more in-depth review before it can land.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefer new_url to match the style of the rest of the file

Standard8 added a commit that referenced this pull request Mar 26, 2014
Bug 987597: Send an caller identifier when obtaining a call-url. r=Standard8
@Standard8 Standard8 merged commit 3cea7d7 into loop-ui-initial Mar 26, 2014
adamroach added a commit that referenced this pull request Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants