Bug 987597: Send an caller identifier when obtaining a call-url#6
Conversation
There was a problem hiding this comment.
you don't need to pass the simplepushURL here, I think?
|
I think there's two more things we need to address:
|
|
@Standard8 do we really need a renew button right now? The UX seems to not be clear enough here. |
|
I think we should have a clear button (or create new url), so that people can generate a new URL, but renew isn't right IMO. |
|
For the sake of clarify, we want a button to go back to the previous view instead of the renew button. |
There was a problem hiding this comment.
Ok, now what's up with the extra space before the equals ;-)
There was a problem hiding this comment.
Oh, I take that comment back, it wasn't clear it was aligning with the = on the line above.
|
Basic outline of changes looks good, either myself or @dmose will need to give this a test & slightly more in-depth review before it can land. |
There was a problem hiding this comment.
nit: prefer new_url to match the style of the rest of the file
Bug 987597: Send an caller identifier when obtaining a call-url. r=Standard8
https://bugzilla.mozilla.org/show_bug.cgi?id=987597