Bug 985596 Set up initial desktop conversation window#10
Merged
Standard8 merged 1 commit intoloop-ui-initialfrom Apr 2, 2014
Merged
Bug 985596 Set up initial desktop conversation window#10Standard8 merged 1 commit intoloop-ui-initialfrom
Standard8 merged 1 commit intoloop-ui-initialfrom
Conversation
Collaborator
There was a problem hiding this comment.
We'll need another MLP-blocker to track getting the various changes to stuff outside of browser/components/loop fixed up and reviewed by a Firefox peer before landing.
Collaborator
|
Looks good; r=dmose with the above changes addressed. But see the note in the bug before merging, however. |
Standard8
added a commit
that referenced
this pull request
Apr 2, 2014
Bug 985596 Set up initial desktop conversation window. r=dmose
Standard8
pushed a commit
that referenced
this pull request
May 29, 2014
ekr
added a commit
that referenced
this pull request
Sep 17, 2014
added test cases with two initial audio and video streams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets a basic conversation window up and running - when a push notification is received, the conversation window will be opened and automatically start the call (controls to come later). This makes it possible for the complete round-trip call to be set up.
This uses a lot of code from the shared directories, so the main glue here is the html and the ConversationRouter.
Client.js has moved out to the shared directory and is in loop-client already.
I'm not intending that we land LoopService.js without major rework, but I cleaned it up a bit anyway so that it didn't have unnecessary comments & debug.