fix: add type declaration paths to exports field#341
Merged
wdavidw merged 3 commits intoadaltas:masterfrom Jul 10, 2022
Merged
Conversation
Member
|
In |
Contributor
Author
|
Done. Copy paste 🤦 The |
5660ca1 to
fb1b21c
Compare
HebertMedeloAdl
approved these changes
Jul 7, 2022
0c72e42 to
8bc2d61
Compare
wdavidw
added a commit
to andipaetzold/node-csv
that referenced
this pull request
Jul 10, 2022
wdavidw
added a commit
to andipaetzold/node-csv
that referenced
this pull request
Jul 10, 2022
44a3005 to
3cfe8f2
Compare
3cfe8f2 to
a5c5ea9
Compare
Member
|
Thank you for your insights!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With TypeScript 4.7, a new
modulewas introduced:Node16. https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#esm-nodejsWhen using strict mode with module Node16, you receive the following error message because the type declaration cannot be found:
Reproduction
Create a new project with the following dependencies
typescript: 4.7.2csv-stringify: 6.1.0Create the following files:
When building the project, you receive the error message above.
Solution
This issue can be solved by adding the
typesto theexportsfield in package.json