tinyusb: MIDI - split descriptor initializer into individual sections#179
Merged
hathach merged 1 commit intoadafruit:masterfrom Oct 4, 2019
kaysievers:tinyusb-midi-jacks
Merged
tinyusb: MIDI - split descriptor initializer into individual sections#179hathach merged 1 commit intoadafruit:masterfrom kaysievers:tinyusb-midi-jacks
hathach merged 1 commit intoadafruit:masterfrom
kaysievers:tinyusb-midi-jacks
Conversation
This allows to compose the descriptor programmatically. The calling code can compose a MIDI descriptor with up to 16 virtual wires/jacks at initialization time. Tested with the tinyusb -> MIDI -> midi_test example. This commit should not change any behavior, future extensions of the calling MIDI device will make use of it.
hathach
approved these changes
Oct 4, 2019
Member
hathach
left a comment
There was a problem hiding this comment.
Thank you for your PR and patient. I was quite busy and is at a middle of other works when you submitting this issue.
hathach
added a commit
to adafruit/Adafruit_nRF52_Arduino
that referenced
this pull request
Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to compose the descriptor programmatically. The calling code
can compose a MIDI descriptor with up to 16 virtual wires/jacks at
initialization time.
Tested with the tinyusb -> MIDI -> midi_test example. This commit should
not change any behavior, future extensions of the calling MIDI device
will make use of it.