Skip to content

fix: Remove the user #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZPascal merged 3 commits into from
May 18, 2023
Merged

fix: Remove the user #156

ZPascal merged 3 commits into from
May 18, 2023

Conversation

@ZPascal
Copy link
Collaborator

@ZPascal ZPascal commented Feb 11, 2023 •
edited
Loading

  • The PR removes the user adaption functionality from the token case.

Related issues:

@ZPascal ZPascal mentioned this pull request Feb 12, 2023
Closed
@ZPascal ZPascal marked this pull request as ready for review February 26, 2023 08:03
@ZPascal ZPascal requested a review from ad-m February 26, 2023 08:03
@ZPascal ZPascal mentioned this pull request Apr 21, 2023
Closed
@ZPascal
Copy link
Collaborator Author

ZPascal commented May 17, 2023

Hi @jackton1, could you please review the PR?

tonyejack1
tonyejack1 approved these changes May 17, 2023
View reviewed changes
Copy link

@tonyejack1 tonyejack1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ZPascal. I’ll suggest adding the blank line at the end of the start.sh

@ZPascal
Copy link
Collaborator Author

ZPascal commented May 18, 2023

@tonyejack1 I've fixed it. Thank you for the review.

@ZPascal ZPascal merged commit 75ba9fb into ad-m:master May 18, 2023
@ZPascal ZPascal deleted the ISSUE-151 branch May 18, 2023 05:12
@ZPascal ZPascal restored the ISSUE-151 branch May 18, 2023 08:12
@ZPascal ZPascal deleted the ISSUE-151 branch May 18, 2023 08:12
ZPascal added a commit that referenced this pull request May 18, 2023
@ZPascal
Revert "fix: Remove the user (#156)"
fb8614a 
This reverts commit 75ba9fb.
@ZPascal ZPascal mentioned this pull request May 18, 2023
Merged
ZPascal added a commit that referenced this pull request May 18, 2023
@ZPascal
Revert "fix: Remove the user (#156)" (#168)
c361e2b 
This reverts commit 75ba9fb.
@ZPascal ZPascal restored the ISSUE-151 branch May 18, 2023 17:35
@ZPascal ZPascal deleted the ISSUE-151 branch May 18, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ad-m ad-m Awaiting requested review from ad-m

1 more reviewer

@tonyejack1 tonyejack1 tonyejack1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZPascal @tonyejack1