Add validation for the percentage values#228
Closed
ratonalgaze wants to merge 1 commit intoactuallymentor:mainfrom
Closed
Add validation for the percentage values#228ratonalgaze wants to merge 1 commit intoactuallymentor:mainfrom
ratonalgaze wants to merge 1 commit intoactuallymentor:mainfrom
Conversation
The valid percentage values are 0-100. The script will exit if the value is invalid for "charge" and "discharge" commands and will apply additional validation for the other two valid values for the "maintain" command.
Owner
|
Ah I just merged #233 that aims to fix the same. Do you agree with the solution in that PR as well @ksgubanov? |
Author
|
@actuallymentor #233 adds validation only for the 'charge' command and doesn't validate input of the 'discharge' and 'maintain'. |
Merged
Author
|
Closed in favor of #253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The valid percentage values are 0-100.
The script will exit if the value is invalid for "charge" and "discharge" commands and will apply additional validation for the other two valid values for the "maintain" command.
Closes #210