Skip to content

Battery level can be set to more than 100% #210

@ratonalgaze

Description

@ratonalgaze

What is the issue? (required)
the 'battery charge' CLI command accepts numbers more than 100%

What exactly did you do to produce the issue? (required)
Steps to reproduce the behavior:

  1. Execute command 'battery charge 250'
  2. Observe the successful command execution(infinite waiting to reach the provided value)

Expected behavior (required)
The command should, according to its description in the help output, whether inform the user about the invalid parameter and stop execution or to limit the value to the maximal allowed (100)

Screenshots (optional)
Would not differ from the "Error logs" section

Error logs

> battery charge 250
12/07/23-15:36:02 - Killing running maintain daemons & enabling charging as default state
12/07/23-15:36:02 - Disabling daemon at gui/501/com.battery.app
12/07/23-15:36:02 - 🔌🔋 Enabling battery charging
12/07/23-15:36:02 - 🔼🪫 Disabling battery discharging
12/07/23-15:36:02 - 💡 Setting magsafe color to
12/07/23-15:36:02 - Battery at 100% (charge; remaining), smc charging enabled
12/07/23-15:36:02 - Setting adapter to on
12/07/23-15:36:02 - Killing running maintain daemons & enabling charging as default state
12/07/23-15:36:02 - Disabling daemon at gui/501/com.battery.app
12/07/23-15:36:02 - 🔌🔋 Enabling battery charging
12/07/23-15:36:02 - 🔼🪫 Disabling battery discharging
12/07/23-15:36:02 - 💡 Setting magsafe color to
12/07/23-15:36:02 - Battery at 100% (charge; remaining), smc charging enabled
12/07/23-15:36:02 - 🔽🪫 Enabling battery discharging
12/07/23-15:36:02 - Charging to 250% from 100%
12/07/23-15:36:02 - 🔌🔋 Enabling battery charging
12/07/23-15:36:02 - 🔼🪫 Disabling battery discharging
12/07/23-15:36:02 - Battery at 100%
12/07/23-15:37:02 - Battery at 100%
12/07/23-15:38:02 - Battery at 100%

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions