Update MagSafe LED if threshold reached when AC charger is connected#184
Merged
actuallymentor merged 2 commits intoactuallymentor:mainfrom Jun 28, 2024
Merged
Conversation
|
ah, yes, this was my request. did this get reviewed and merged? (i know nothing about coding :)) just here for the good open source software. |
Contributor
Author
Not yet, it's still in the PR list... |
Owner
|
Very dope, sorry for the delay in merging! |
panoskava
pushed a commit
to panoskava/battery
that referenced
this pull request
Mar 17, 2026
Update MagSafe LED if threshold reached when AC charger is connected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the charge is above the threshold when the AC charger is connected (i.e the charger was attached when the battery was above e.g. 80%), turn the MagSafe LED green on the next iteration.