Battery calibration#169
Conversation
|
Looking good for me 👍 |
|
Great job, seems good! 👍🏻 |
actuallymentor
left a comment
There was a problem hiding this comment.
I think this command would be more useful it it runs in the background without needing to be foreground in a terminal. In addition to the comments here, it would be very useful if you could:
- Rename your function from
calibratetocalibrate_syncronous - Add a function
calibrateand model it after the maintain function - This function should use a new
$calibrate_pidfile battery maintainandbattery maintain_synchronousshould check for$calibrate_pidfileand if it exists exit withCalibration is running, please run "battery calibrate stop" or wait for it to finish
I understand this increases the scope of this PR a lot, but it would take it to a great level of user-experience.
battery.sh
Outdated
| # Discharge battery to 15% | ||
| battery discharge 15 | ||
|
|
||
| while true; do |
There was a problem hiding this comment.
For this, please use the built in battery charge command. When battery charge 100 is done, the command exits and lets your script continue
There was a problem hiding this comment.
If I use "battery charge 100" won't it start battery discharging after the execution? I need to wait 1 hour before discharging process. @actuallymentor
|
I've done the calibration checking, i wait for others. |
|
What do you think if during the calibration the magsafe led will blinking in orange? @actuallymentor |
I think that's a very cool idea! Do make sure to:
|
I was checking about it but the led is continuously overwritten by other commands. Maybe something for the future! |
|
looks good to me |
|
Tested on Macbook Air M2, looks good! |
actuallymentor
left a comment
There was a problem hiding this comment.
Thank you ver much for this PR @KyrosWeb!
My apologies for only getting to it so late.
I've requested some clarifications/edits, but they are quite minor. Let me know what you think and add edits to the extent that you think they make sense.
I have some bandwidth this week so will respond quicker than I have over the past months :)
|
@actuallymentor Check for the commit. |
|
Apologies for "butting in" at this late date, but... Just out of curiosity, did the authors consult this article: Testing and Calibrating Smart Batteries in the development of this PR? I ask because I've not seen any mention of "Impedance Tracking"... I wonder if Apple actually uses this technology? It's been available in hardware for a while, but no idea how - or if - Apple has implemented it. And please don't misunderstand; I think the PR is a sound idea, but I couldn't help but wonder if Apple might have implemented impedance tracking - and if anyone has given thought as to how to learn if they have - and how to take advantage of it if they have. |
|
@seamusdemora Hi , Yes i read it all and i think the process of discharging and recharging the battery when it stay lots of time stuck in a percentage is important to preserve the battery life and in order to avoid these situations : #191 |
|
@KyrosWeb : P.S. I liked the approach except for the "blinking light" :) IMHO that might be distracting? |
|
@seamusdemora Hi , it will be included soon. I haven’t insert anymore the blinking light for your happiness 😂 |
|
@KyrosWeb That is good to hear. I'm currently evaluating P.S. Yes, you have made me very happy :) |
|
I'm looking forward to the release of this version with calibration:) |
We need to wait the repo owner. |
|
can we get a merge pls |
|
@actuallymentor Hey, no news for PR? |
|
Apologies on the delay, merged! Thank you for your work @KyrosWeb! Please keep an eye on the issues tab the coming weeks to make sure to catch any issues :) |
|
It's only been 4 ½ months - there's no rush; you need to take it easy! |
Battery calibration
Allow battery tool to discharge your battery until it reaches 15%. When the 15% is reached, it will fully recharge the battery and keep it at 100% for 1 hour.Finally the battery will be discharged until it reaches 80% and will be kept on this percentage.
From what I understand it would be advisable to calibrate the battery about every 3 months of continuous use at 80%