feat: Minimal example for using C++20 concepts#2034
Merged
kodiakhq[bot] merged 8 commits intoacts-project:mainfrom Apr 17, 2023
Merged
feat: Minimal example for using C++20 concepts#2034kodiakhq[bot] merged 8 commits intoacts-project:mainfrom
kodiakhq[bot] merged 8 commits intoacts-project:mainfrom
Conversation
Member
Author
|
The concept is intentionally wrong (takes a reference instead of a pointer) to showcase the error we (hopefully) get in the CI. |
Codecov Report
@@ Coverage Diff @@
## main #2034 +/- ##
=======================================
Coverage 49.85% 49.85%
=======================================
Files 421 421
Lines 23889 23889
Branches 10843 10843
=======================================
Hits 11911 11911
Misses 4357 4357
Partials 7621 7621
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
📊 Physics performance monitoring for b305417Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Member
|
Ah didn't read the comment that it should fail |
Member
Author
|
It did fail, and then I fixed the concept, so now we indeed expect success. |
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
This adds a very simple `SurfaceVisitorConcept` to test the conditional implementation.
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
This adds a very simple `SurfaceVisitorConcept` to test the conditional implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a very simple
SurfaceVisitorConceptto test the conditional implementation.