Skip to content

[v3] Rails 8.1 compatibility, drop Ruby < 3.0 #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tagliala merged 1 commit into from
Oct 25, 2025
Merged

[v3] Rails 8.1 compatibility, drop Ruby < 3.0 #8839

tagliala merged 1 commit into from
Oct 25, 2025

Conversation

@tagliala
Copy link
Contributor

@tagliala tagliala commented Oct 23, 2025

No description provided.

@tagliala tagliala changed the base branch from master to 3-0-stable October 23, 2025 21:54
@tagliala tagliala changed the title Feature/rails 81 WIP Feature/rails 81 Oct 23, 2025
@tagliala tagliala changed the title WIP Feature/rails 81 WIP Feature/rails 81 - 3.0 Oct 23, 2025
@tagliala
Copy link
Contributor Author

tagliala commented Oct 23, 2025

I'm not sure about

/home/runner/work/activeadmin/activeadmin/tmp/test_apps/rails_81/app/controllers/application_controller.rb:6:in `<class:ApplicationController>': undefined local variable or method `stale_when_importmap_changes' for ApplicationController:Class (NameError)

  stale_when_importmap_changes

importmap it's there, this is a new line in 8.1

@tagliala
Copy link
Contributor Author

tagliala commented Oct 25, 2025

Failing when executing

# Setup Active Admin
generate "active_admin:install"

@tagliala tagliala force-pushed the feature/rails-81 branch 6 times, most recently from 0be141e to bdc172b Compare October 25, 2025 18:00
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (3-0-stable@7f2afe6). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff              @@
##             3-0-stable    #8839   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4971           
  Branches              ?        0           
=============================================
  Hits                  ?     4931           
  Misses                ?       40           
  Partials              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tagliala tagliala changed the title WIP Feature/rails 81 - 3.0 Rails 8.1 compatibility, drop Ruby < 3.0 Oct 25, 2025
@tagliala tagliala changed the title Rails 8.1 compatibility, drop Ruby < 3.0 [v3] Rails 8.1 compatibility, drop Ruby < 3.0 Oct 25, 2025
@tagliala tagliala marked this pull request as ready for review October 25, 2025 18:04
javierjulio
javierjulio approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javierjulio javierjulio requested a review from mgrunberg October 25, 2025 18:45
@tagliala
Add Rails 8.1 compatibility
9bc38f5 
Additionally:
- Drop ruby < 3.0
- Bump minor version number
tagliala
tagliala commented Oct 25, 2025
View reviewed changes
@tagliala tagliala merged commit 5a8442d into 3-0-stable Oct 25, 2025
29 checks passed
@tagliala tagliala deleted the feature/rails-81 branch October 25, 2025 19:58
@luizkowalski
Copy link

luizkowalski commented Oct 28, 2025

hey 👋🏻
any chance you can cut a new v3 release?

thanks

@tagliala
Copy link
Contributor Author

tagliala commented Oct 31, 2025

@mgrunberg 3-0-stable branch should be ready for a 3.4.0 release, whenever you want

@mgrunberg
Copy link
Contributor

mgrunberg commented Nov 3, 2025

@mgrunberg 3-0-stable branch should be ready for a 3.4.0 release, whenever you want

Thanks! I released 3.4.0

@dalibor dalibor mentioned this pull request Nov 5, 2025
Merged
tagliala added a commit that referenced this pull request Dec 13, 2025
@tagliala
Bump minimum required Ruby version to 3.0
02bc1a0 
The changes introduced in #8839 dropped support for all Ruby versions
below 3.0, but the gemspec had not yet reflected this.

Update the gemspec to set the minimum required Ruby version to 3.0,
aligning documentation and configuration with the currently supported
runtime.
@tagliala tagliala mentioned this pull request Dec 13, 2025
Merged
tagliala added a commit that referenced this pull request Dec 13, 2025
@tagliala
Bump minimum required Ruby version to 3.0 (#8885)
ec12b3b 
The changes introduced in #8839 dropped support for all Ruby versions
below 3.0, but the gemspec had not yet reflected this.

Update the gemspec to set the minimum required Ruby version to 3.0,
aligning documentation and configuration with the currently supported
runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javierjulio javierjulio javierjulio approved these changes

@mgrunberg mgrunberg Awaiting requested review from mgrunberg

Assignees

No one assigned

Labels

type enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tagliala @luizkowalski @mgrunberg @javierjulio