Template and styles fixes#8207
Merged
Merged
Conversation
This argument has been removed so we can't default to it. For now we intend to support v1 and v2 of importmap-rails since breaking changes are only around defaults. If users don't want the shim but want to remain on v1 they can modify this template.
The previous change fixes the bug report template workflow failure but here we'll want to stick to the current version.
Trying this out in a few apps wasn't always picked up. It doesn't follow how we typically do other CSS here so this should play nicer with Tailwind's content look up so no need to specify these in a safelist. Since this is already prefixed with data-table- in the name, no need to scope to the data-table class, like we do with data-table-resource-actions and other classes. This also sets a fixed width and height on the icon since in some cases the SVG can get cut off at the bottom portion. It's not replicable on our dev generated app, or on demo but can occur.
The script now runs quickly since we no longer have to install sassc. This used to be much slower. For example, runs for a couple of months ago, could be as slow as 3 minutes whereas now it runs in about 30 seconds or less. GitHub no longer documents the approach we took with the empty workflow and paths/paths-ignore so we'll consolidate into one workflow using the changes-files action. Since this is now fast, we want to run this on any PR with applicable files changed to get feedback, rather than fail on a schedule and realize then that something is wrong. In this case it was the release of importmap-rails v2 and a deleted argument.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8207 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 140 140
Lines 4013 4013
=======================================
Hits 3977 3977
Misses 36 36 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the data-table-sorted-icon style so it's picked up automatically by Tailwind's content search and also with a fixed width/height since in some cases it can be cut off. This also fixes the bug report template script workflow that failed on a scheduled run due to the importmap-rails v2 release. The
shimargument was removed so the html head template was updated to remove it.