Update FR locales#8193
Merged
Merged
Conversation
javierjulio
reviewed
Dec 29, 2023
javierjulio
left a comment
Member
There was a problem hiding this comment.
@thibaudgg thanks! We are just missing the following Kaminari pagination updates here. Would you be ok with translating and adding these in?
en:
views:
pagination:
previous: "Previous"
next: "Next"
The reason for the override is to remove the HTML entities that Kaminari adds to just use text. We only need to translate these two words since we don't use the first/last links now.
javierjulio
reviewed
Dec 29, 2023
This patch updates the French locales to be inline with the latest changes in the English ones. More details about the changes can be found in the v4 upgrade guide: activeadmin#8182
eb4e1cb to
6a8a0b4
Compare
Contributor
Author
|
@javierjulio just added the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8193 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 151 151
Lines 4150 4150
=======================================
Hits 4110 4110
Misses 40 40 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates the French locales to be in line with the latest changes in the English ones.
More details about the changes can be found in the v4 upgrade guide: #8182