Move kaminari templates to active_admin folder#8190
Merged
Conversation
Since it will be expected for users to extract many partials in v4, it would help to have all templates under the active_admin folder. Previously, we had Kaminarin in the default location but Kaminari has a views_prefix option we can set. https://github.com/kaminari/kaminari#multiple-templates With this that means the our custom templates can now live in app/views/active_admin/kaminari and be within the active_admin folder along side all other templates that can be extracted.
I've tested with our generated app that if it specifies its own Kaminari templates or doesn't, it still won't pick up the ActiveAdmin theme so we are good.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8190 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 151 151
Lines 4150 4150
=======================================
Hits 4110 4110
Misses 40 40 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have many partials now that users will be able to copy and modify, it would help to have the Kaminari templates live under the same
app/views/active_admindirectory. Kaminari has aviews_prefixoption that we should use over thethemeoption. I've tested this with our locally generated dev app to simulate a host using either Kaminari defaults or their own partial overrides, and those have no impact on ActiveAdmin Kaminari templates and vice versa so this is a safe change.