Refactor download format links helper#8185
Merged
Merged
Conversation
This is undocumented. No need to provide since the formats can be set through the download_links config which is preferred. We'll update our config initializer template to note that the format must be registered with mime type if it isn't. Eventually, we'll remove the XML and JSON defaults along with the respond_to for security reasons since they are still accessible as public routes even without links. Users should declare this for each resource where they need it.
2be82a5 to
b1a86f2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8185 +/- ##
==========================================
- Coverage 99.04% 99.03% -0.01%
==========================================
Files 152 151 -1
Lines 4173 4151 -22
==========================================
- Hits 4133 4111 -22
Misses 40 40 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the download format links since there's no need for
formatsandadd_formatmethods. The latter is already set via config which is preferred. The config initializer template has been updated to note that the format must be registered with mime type if it isn't. We will look into removing therespond_to :xml, :jsondefaults for security reasons since download formats are accessible without links and can expose resource and associated data.