Inline more styles into extracted partials#8178
Merged
Merged
Conversation
With the extract template we can now inline the grid layout styles and use an explicit named class for setting a link default style in content area, this way it can also be easily removed if not desired.
Remove commented template Remove unused font size base variables
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8178 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 152 152
Lines 4243 4243
=======================================
Hits 4201 4201
Misses 42 42 ☔ View full report in Codecov by Sentry. |
Apply link default style component to links partial to retain previous styling that was removed.
These elements won't exist, although they could, we still need to protect against the fact they may not be there. We can use JS optional chaining operator here.
If the system preference was used and it happen to be light mode and the user had not used this switch, then when toggling for the first time nothing would change because it would set the theme key to light mode when it already was. This updates the logic to match what we do when setting the theme so it has the correct, expected behavior.
a4e338f to
0c596ad
Compare
This is the default already which is what we want to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've extracted the initial set of customizable templates, we can inline more Tailwind styles in those templates for users to customize without having to change CSS. Some styles will have to remain as components. In the future, it would be nice to extract more partials, for example, a default for comments or other components. This also includes some bug fixes for the dark mode toggle JS.