Prep Tailwind CSS migration part 7#8155
Merged
Merged
Conversation
4c7bd00 to
ad5f6eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8155 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 175 175
Lines 4603 4625 +22
=======================================
+ Hits 4557 4579 +22
Misses 46 46 ☔ View full report in Codecov by Sentry. |
f278e2b to
c2fc09b
Compare
Adds new ids for main and user menus.
Tested that this file would not be included by default by running `npm publish --dry-run` which lists the files in the tarball contents. After updating the files array and rerunning the command, the file is now included.
This updates our Component base class to only apply a default CSS class name if present. This also resolves the issue around the switch_index_view feature test so we can re-enable that.
If this div element is there an empty, it will affect the flex layout since we use gap property to control spacing at the parent level.
Still some problems with the width defaulting to the size of the button when considering desktop and mobile viewports. This is the best we can do for now. One consideration is we can apply a custom class for batch actions and (table) actions so we can set a default width. That will render a bit nicer and more inline with how frameworks style dropdowns.
The comments component is now just a plain div component and no longer relies on panel. The styles are further cleaned up.
By default Formtastic disables form client side validation with novalidate="novalidate" boolean attribute, regardless if we set input html with required boolean.
This updates the icons used as well. The notice type now uses a checkmark, the alert type uses an info icon and the error type uses the exclamation mark icon. Added a flash_error CSS class for error type since used by Devise and a few places in our code base too. This simplifies the layout spec as it was failing intermittently with the flash_messages partial extraction. Since we only have 2 unit tests for a simple method. We don't need to create a whole admin app. The lang attributes test is safe to remove as we have an integration test (cucumber) to ensure it works as expected. Updates the page base test to add and remove the necessary constant so we clean up properly.
Also adds overflow hidden to for the rounded corners. We'll have to readjust.
c2fc09b to
e4d07c9
Compare
e4d07c9 to
30a2ba5
Compare
This now requires Arbre v2 as the minimum since a key change was a bad commit around handling empty attributes. We can now use an empty attributes safely as it will be output to HTML as expected. This act as boolean/presence attributes.
30a2ba5 to
8369ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates component styles after testing in both desktop and mobile. The Component class will add a default CSS class name only if one is provided through the
default_class_nameprotected method, otherwise there is no default. Arbre v2 will no longer add a default class name either. This also requires Arbre v2+ now. Flash messages has been extracted into a partial since it's used in both Devise and ActiveAdmin templates. This bumps Flowbite to 2.2.0 and addresses a breaking change with modal init.When publishing our NPM package, it's critical that the root
plugin.jsfile is included otherwise it's not there (did a dry-run). From testing, we'll need to rely onplugin.jsfrom the NPM package as the gem path trick doesn't work in the wild.