Prep Tailwind CSS migration part 5#8122
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8122 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 184 184
Lines 4740 4745 +5
=======================================
+ Hits 4695 4700 +5
Misses 45 45
☔ View full report in Codecov by Sentry. |
c64d12e to
5a9f572
Compare
We can remove the active_admin_countless theme since all that did differently was not include the first/last links. With out updated pagination theme, we are no longer using first/last links but just next/previous instead. The outermost first and last page number link will be visible so that is its replacement. With that, that means we can remove this extra theme as its no longer needed. This also updates the pagination locale text to be shorter, matching modern designs. The paginated_collection component layout has been updated so the first row contains the paging info and links while the second row has the optional per page selector and download links.
Common layout for this is to always have the comment form first and then the list of comments.
Since table_for can be used directly, and its a component vs just a plain table tag, we want to use the same component class for table_for and index_as_table so they are styled the same. We don't want to apply table styles using a tag selector, nor require users to manually add a class if using table_for directly.
This helps testing a responsive table (horizontally scrollable)
Use some sample lorem sentences to generate random bodies of text for posts and comments. This also bumps the number of each created to help test pagination.
Since we generate an app for local dev in `tmp/development_apps/rails_*` we need to hard code a relative path to the project root. The default value for this is to run `bundle show activeadmin` but that will only work from outside this repo.
This is something Flowbite declared but even before v2 wasn't using in their docs.
We don't want borders on tooltips. The common pattern is its just a solid background color with a shadow. Easier to maintain. Also no need for :after selector on data-popper-arrow as we just need a single psuedo element.
5a9f572 to
c956db0
Compare
Using latest value per HTML5 Boilerplate https://github.com/h5bp/html5-boilerplate/blob/main/src/index.html
c956db0 to
1fd2b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the style updates for pagination and consolidates to a single kaminari theme. The active_admin_countless theme has been removed as it's no longer needed. The original theme can handle the
pagination_total: falsecase. The layout and styles for Comments have been been mostly completed. Flowbite was updated to v2. Both index-table and directtable_forusage, now apply the samedata-tableCSS class so they are styled the same.