Backport minor changes to v3 stable branch#8097
Merged
Merged
Conversation
All except for one was to do with whitespace. We want to reduce code footprint and use off-the-shelf tools for basic checks like these. Since they aren't critical we are fine without replacements other than what eslint and rubocop already offer. The sass-rails lint was for webpacker but we have already removed webpacker support. We won't be using any images or asset URLs in the new v4 approach for assets.
Ran `bin/bundle update` Ran `yarn upgrade-interactive --latest` Note this updates the default gemfile to use Rails 7.1 but we are good with that for our 3-0-stable branch.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8097 +/- ##
==============================================
+ Coverage 99.16% 99.18% +0.02%
==============================================
Files 195 195
Lines 4934 4934
==============================================
+ Hits 4893 4894 +1
+ Misses 41 40 -1 ☔ View full report in Codecov by Sentry. |
faizaankhan
pushed a commit
to bugcrowd/activeadmin
that referenced
this pull request
Dec 28, 2023
* Remove link rake task All except for one was to do with whitespace. We want to reduce code footprint and use off-the-shelf tools for basic checks like these. Since they aren't critical we are fine without replacements other than what eslint and rubocop already offer. The sass-rails lint was for webpacker but we have already removed webpacker support. We won't be using any images or asset URLs in the new v4 approach for assets. * Add metadata to activeadmin.gemspec (activeadmin#8012) * Optimize data generation with insert_all * Mention Ransack allowlist in documentation (activeadmin#8043) * Update .gitignore * Update all outdated dependencies Ran `bin/bundle update` Ran `yarn upgrade-interactive --latest` Note this updates the default gemfile to use Rails 7.1 but we are good with that for our 3-0-stable branch. --------- Co-authored-by: John DeSilva <desilvjo@umich.edu> Co-authored-by: Francesco Belladonna <francesco@fc5.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports some minor changes to the new 3-0-stable branch that were introduced just after we cut the v3.0.0 release that would be helpful to have here. We are setting up this stable branch so we can cut a new v3.x release to allow Rails 7.1 by removing upper bound dependency limits like we've done in InheritedResources and Arbre to ease maintenance.