Remove old, since replaced JS#8040
Merged
Merged
Conversation
This simplifies our JS setup quite a bit. The terser plugin had to be replaced since its now an official Rollup plugin. Several other NPM packages we no longer need either. No plans to transpile so Babel is also removed. Instead of an active_admin/base.js this now creates an active_admin.js file.
We had no test page using this in our sample app.
This wasn't being loaded while in transition. It has already been replaced with a plain vanilla JS setup using modern standards. We no longer use jQuery or jQuery UI either.
Also resolves Rubocop warning with layout argument alignment.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #8040 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 185 185
Lines 4731 4730 -1
==========================================
- Hits 4686 4685 -1
Misses 45 45
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've already replaced this old JS with a vanilla JS version. This removes jQuery and jQuery UI fully. We bundle our JS like we did before. This works well with Sprockets and should continue to work with Propshaft. I believe this same bundle would work with jsbundling-rails too but we aren't requiring that.