Prep Tailwind CSS migration part 2#8036
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #8036 +/- ##
==========================================
+ Coverage 98.35% 98.89% +0.53%
==========================================
Files 187 184 -3
Lines 4744 4698 -46
==========================================
- Hits 4666 4646 -20
+ Misses 78 52 -26
☔ View full report in Codecov by Sentry. |
4e62ee3 to
629fb3e
Compare
These have been replaced.
This also updates the locale keys for pagination to be less wordy and long. Will follow up to extract the Tailwind CSS classes.
The action items are rendered directly into the container so no need for multiple span wrappers with a component which are undesired anyway. The DSL is meant to easily add what action item you want vs implying it has to be a link and styled a certain way.
This now works with Flowbite and has simpler implementation. The item method now takes a block so anything can be added e.g. horizontal divider or other control. We must have coverage through another test, but wouldn't hurt to have a simple unit test for DropdownMenu. This covers the new feature where item now takes an optional block to render any content besides the default link. We can expand this spec further.
This is a work in progress. The plan is to have the global navigation always be a vertical drawer menu since the common case is to have many pages. This will allow us to more easily support different viewports as well.
629fb3e to
5e27810
Compare
We already commented out the batch actions feature temporarily as a follow up with migrate over the batch actions form DSL replacement. This is to just appease code coverage for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.