Remove multiline ternary operator#8034
Merged
javierjulio merged 1 commit intoOct 7, 2023
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8034 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 185 185
Lines 4730 4733 +3
=======================================
+ Hits 4685 4688 +3
Misses 45 45
☔ View full report in Codecov by Sentry. |
084bc25 to
7238c67
Compare
7238c67 to
9535a20
Compare
javierjulio
reviewed
Oct 6, 2023
Replace multiline ternary operator with a standard `if...else` for readability and better code coverage
9535a20 to
3a62c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace multiline ternary operator with a standard
if...elsefor readability and better code coveragemaster
Fake Coverage 100%
this branch
Real Coverage 96.43%