Skip to content

support i18n#170

Closed
Yuki-Inoue wants to merge 3 commits intoactive-hash:masterfrom
Yuki-Inoue:i18n
Closed

support i18n#170
Yuki-Inoue wants to merge 3 commits intoactive-hash:masterfrom
Yuki-Inoue:i18n

Conversation

@Yuki-Inoue
Copy link
Contributor

@Yuki-Inoue Yuki-Inoue commented Feb 2, 2019 •
edited
Loading

This PR makes ActiveHash support i18n if I18n is available.

With this fix, model's model_name will be configurable by locale file, for example:

ja:
  activemodel:
    models:
      country: "国" # Country.model_name.human # => "国"

syguer
syguer reviewed Feb 4, 2019
View reviewed changes
@syguer
Copy link
Collaborator

syguer commented Feb 4, 2019

Thank you for your contribution. Sounds good!
Could you write test codes and write short document to README.md?
If you are busy, I'll help these job 👍

@Yuki-Inoue
Copy link
Contributor Author

Yuki-Inoue commented Feb 4, 2019

@syguer Thanks for the review. The point out you've made is fixed with the next commit.

About the document/testing, I'll try. Document is relatively easy, whereas the test it might take some time for me to figure out how to setup... (all the locale setup usually made by rails, I find it not obvious how to write tests...)

@Yuki-Inoue
Copy link
Contributor Author

Yuki-Inoue commented Feb 4, 2019

README is updated.

@yhirano55
Copy link
Contributor

yhirano55 commented Jan 28, 2020

It looks nice work to me 👏 I would like to know why this pull request is not merged.

@Yuki-Inoue
Copy link
Contributor Author

Yuki-Inoue commented Mar 19, 2020

From where I remember, I was asked to write tests.
I tried to do so, but had trouble; I couldn't figure out how to write test for this kind of feature.

I would be glad if anyone can help...

@ryu-sato ryu-sato mentioned this pull request Jun 17, 2021
Merged
1 task
@kbrock
Copy link
Collaborator

kbrock commented Jul 29, 2025

Hi, #230 was merged. Does this meet your needs or do you need something else?

@kbrock
Copy link
Collaborator

kbrock commented Aug 4, 2025

Thank you for your work.

Looks like 230 was based upon this PR, but with tests.
Closing this as we now support i18n.

Please reopen if there is still outstanding work to be done here.

@kbrock kbrock closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syguer syguer syguer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yuki-Inoue @syguer @yhirano55 @kbrock