chore(ci): update dependencies#891
chore(ci): update dependencies#891mmorel-35 wants to merge 1 commit intoactions:mainfrom mmorel-35:main
Conversation
|
Hey @mmorel-35 -- thanks for opening the PR. I see there are lots of changes here:
You can help us out and increase your chances of your PR getting merged if you scope down to one specific thing. It's ok to submit multiple PRs for separate issues. Also, if you can give more context in the description on the problem you are solving, that will be much appreciated as well. Thanks! |
|
Hi @brcrista , I'm going to start by focusing on dependencies updates then |
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-Authored-By: MOREL Matthieu <matthieu.morel@cnp.fr> Co-Authored-By: Matthieu MOREL <mmorel-35@users.noreply.github.com>
| // Start proxy server | ||
| proxyServer = proxy() | ||
| await new Promise(resolve => { | ||
| await new Promise<void>(resolve => { |
There was a problem hiding this comment.
This is required by "typescript": "^4.3.5"
| afterAll(async () => { | ||
| // Stop proxy server | ||
| await new Promise(resolve => { | ||
| await new Promise<void>(resolve => { |
There was a problem hiding this comment.
This is required by "typescript": "^4.3.5"
| isGzip: boolean | ||
| ): Promise<void> { | ||
| await new Promise((resolve, reject) => { | ||
| await new Promise<void>((resolve, reject) => { |
There was a problem hiding this comment.
This is required by "typescript": "^4.3.5"
| jest | ||
| .spyOn(HttpClient.prototype, 'patch') | ||
| .mockImplementation(async (requestdata, data) => { | ||
| .mockImplementation(async (requestUrl, data) => { |
There was a problem hiding this comment.
This is to use the same names as in patch function
| jest | ||
| .spyOn(HttpClient.prototype, 'post') | ||
| .mockImplementation(async (requestdata, data) => { | ||
| .mockImplementation(async (requestUrl, data) => { |
There was a problem hiding this comment.
This is to use the same names as in post function
| async function emptyMockReadBody(): Promise<string> { | ||
| return new Promise(resolve => { | ||
| resolve() | ||
| return new Promise<string>(resolve => { |
There was a problem hiding this comment.
This is required by "typescript": "^4.3.5"
| async function emptyMockReadBody(): Promise<string> { | ||
| return new Promise(resolve => { | ||
| resolve() | ||
| return new Promise<string>(resolve => { |
There was a problem hiding this comment.
This is required by "typescript": "^4.3.5"
| async function emptyMockReadBody(): Promise<string> { | ||
| return new Promise(resolve => { | ||
| resolve() | ||
| return new Promise<string>(resolve => { |
There was a problem hiding this comment.
This is required by "typescript": "^4.3.5"
| "eslint-comments/no-use": "off", | ||
| "github/no-then": "off", | ||
| "import/no-namespace": "off", | ||
| "import/named": "off", |
There was a problem hiding this comment.
This is because of "@typescript-eslint/parser": "^4.29.3"
|
Hi @brcrista, this is ready for review, when you have the time :) |
Hi @luketomlinson ! I have updated the current dependencies with the help of dependabot. When you have a chance to take a look 😊!
It fixes the audit failure by the way.