Skip to content

Implement proposal stated in ADR for setup-dotnet v3 and functionality from feature request #219#315

Merged
dmitry-shibanov merged 19 commits intoactions:mainfrom
IvanZosimov:ADRdotnet
Sep 27, 2022
Merged

Implement proposal stated in ADR for setup-dotnet v3 and functionality from feature request #219#315
dmitry-shibanov merged 19 commits intoactions:mainfrom
IvanZosimov:ADRdotnet

Conversation

@IvanZosimov
Copy link
Contributor

@IvanZosimov IvanZosimov commented Sep 14, 2022

Description:
In the scope of this PR such changes were made:

  1. Installation directories for Windows and Ubuntu were changed to the folder with preinstalled .NET SDKs
  2. Inner logic of interaction with the MS dotnet installer scripts was changed
  3. New input dotnet-quality was added
  4. The current syntax was updated and now allows to specify the prerelease version without using `include-prerelease' input (e.g. 5.0.0-preview.6 right away)
  5. Input "include-prerelease" was cut out because now setup-dotnet by default is able to install a prerelease version of SDK (preview, rc) if it's the latest on the channel (equivalent to setting v2's 'include-prerelease' input to true).

Note: This PR contains breaking changes: 1) Installation directories for Windows and Ubuntu runners were changed

This PR also solves this issue: #251

Related issue:
https://github.com/actions/runner-images-internal/issues/4058
https://github.com/actions/runner-images-internal/issues/4059
https://github.com/actions/runner-images-internal/issues/4060
#219

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

IvanZosimov added 4 commits September 14, 2022 12:34
In the scope of this commit such functionalty was added:
1. Installation directories for Windows and Ubuntu were changed to
the folder with preinstalled .NET SDK's
2. Inner logic of interaction with MS dotnet installer scripts was
 changed
3. New input "dotnet-quality" was added
Such functionality was cut out:
1. Input "include-prerelease"
Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for cleaning up some things as well.

@dmitry-shibanov dmitry-shibanov merged commit 0705ef0 into actions:main Sep 27, 2022
COMPUTERS-bit pushed a commit to COMPUTERS-bit/setup-dotnet that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants