Skip to content

Relink brew packages#7710

Closed
jsoref wants to merge 1 commit intoactions:mainfrom
jsoref:brew-relink
Closed

Relink brew packages#7710
jsoref wants to merge 1 commit intoactions:mainfrom
jsoref:brew-relink

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Jun 13, 2023

Description

Bug fixing
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.

Currently, we can't accept external contributions to macOS source. Please find more details in CONTRIBUTING.md guide

That's really unfortunate because, apparently, currently, macOS runners are hostile to brew, and people often try to use brew 🍺 .

Related issue:

#6868, #11545

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@mikhailkoliada
Copy link
Copy Markdown
Contributor

Hello! This issue is known, it should not be fixed in the runner-images anyhow but rather symlinks must be fixed in the actions/setup-python repository in the issue you mentioned (#11545) cc @dmitry-shibanov for awareness.

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Jun 13, 2023

That's nonsense. Not everyone uses actions/setup-python. And you've fixed it in this repository before: 7ff71c8 -- and you've carried that support through a number of python releases.

This isn't just a problem w/ python, it's also a problem w/ go.

This is a fundamentally broken image, you're shipping a broken brew which when asked to upgrade dies.

https://github.com/jsoref/macos-brew-python/actions/runs/5252745538/jobs/9489182502#step:3:522

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Jun 13, 2023

Here's the most recent thing I tripped on, note again that there's no actions/setup-python and there should be no requirement that people use that or some hypothetical version that has to be adapted to work around a bug in the basic runner image:
https://github.com/check-spelling/mgconsole/actions/runs/5260558139/workflow

Run brew update
...
==> Running `brew cleanup python@3.10`...
Removing: /usr/local/Cellar/python@3.10/3.10.11... (3,122 files, 56.9MB)
Removing: /Users/runner/Library/Caches/Homebrew/python@3.10--3.10.11... (14.6MB)
==> Upgrading python@3.11
  3.11.3 -> 3.11.4 

==> Pouring python@3.11--3.11.4.monterey.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

jsoref added a commit to check-spelling-sandbox/mgconsole that referenced this pull request Jun 14, 2023
jsoref added a commit to check-spelling-sandbox/mgconsole that referenced this pull request Jun 14, 2023
jsoref added a commit to fix-runner/image that referenced this pull request Jun 14, 2023
@maxkratz
Copy link
Copy Markdown

This is a fundamentally broken image, you're shipping a broken brew which when asked to upgrade dies.

I can confirm this. If one pushes a GitHub Actions config that just runs brew update, the Action fails.

Green-Sky added a commit to Green-Sky/llama.cpp that referenced this pull request Jul 3, 2023
until they decide to fix the brew installation in the macos runners.
see the open issues. eg actions/runner-images#7710
Green-Sky added a commit to ggml-org/llama.cpp that referenced this pull request Jul 3, 2023
until they decide to fix the brew installation in the macos runners.
see the open issues. eg actions/runner-images#7710
YuMJie pushed a commit to YuMJie/powerinfer that referenced this pull request Oct 25, 2024
until they decide to fix the brew installation in the macos runners.
see the open issues. eg actions/runner-images#7710
ganminghao pushed a commit to ganminghao/PowerInfer that referenced this pull request Dec 4, 2025
until they decide to fix the brew installation in the macos runners.
see the open issues. eg actions/runner-images#7710
leozoro-cloud added a commit to leozoro-cloud/llama.cpp that referenced this pull request Jan 14, 2026
until they decide to fix the brew installation in the macos runners.
see the open issues. eg actions/runner-images#7710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants