Improve Debugging Messages for Empty Tokens#609
Merged
ethanchewy merged 2 commits intomainfrom Jul 22, 2020
Merged
Conversation
TingluoHuang
approved these changes
Jul 22, 2020
ericsciple
approved these changes
Jul 22, 2020
fabianishere
pushed a commit
to fabianishere/runner
that referenced
this pull request
Aug 24, 2020
* Improve Debugging Messages for Empty Tokens * fix tests
fabianishere
pushed a commit
to fabianishere/runner
that referenced
this pull request
Sep 23, 2020
* Improve Debugging Messages for Empty Tokens * fix tests
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* Improve Debugging Messages for Empty Tokens * fix tests
TingluoHuang
pushed a commit
that referenced
this pull request
Apr 21, 2021
* Improve Debugging Messages for Empty Tokens * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the process for polishing Composite Run Steps, I've revisited my old TODOs.
There’s only one TODO related directly to composite run steps (the other TODOs have to do with nested steps).
Namely:
// TODO: Add a more helpful error message + including file name, etc. to show user that it's because of their yaml fileIn this PR, I add the filename associated with this error as well as add more clear language in the error message. I also change similar error messages that could use some improvement.
Basically, I change the error message for null tokens to say, "You are using <TypeOfAction> but the <TokenName> is empty in <FileRelativePath>".
Example: https://github.com/ethanchewy/testing-actions/runs/898870893?check_suite_focus=true