Create runner layout for osx-arm64 (Apple M1) platform.#1618
Create runner layout for osx-arm64 (Apple M1) platform.#1618TingluoHuang merged 3 commits intomainfrom
Conversation
| # inspect the open file handles to find the node process | ||
| # we can't actually inspect the process using ps because it uses relative paths and doesn't follow symlinks | ||
| path=$(lsof -a -g "$procgroup" -F n | grep node12/bin/node | grep externals | tail -1 | cut -c2-) | ||
| path=$(lsof -a -g "$procgroup" -F n | grep node16/bin/node | grep externals | tail -1 | cut -c2-) |
There was a problem hiding this comment.
should the node16 changes wait on fhammerl's pr?
There was a problem hiding this comment.
Yes, i will rebase on his change once it's merged.
There was a problem hiding this comment.
Looks like #1621 has been merged. Can this PR now be merged? Thanks. This is important to us.
There was a problem hiding this comment.
We're still working on the dependencies for this - here's some more information. #805 (comment) Thanks everybody for your patience!
There was a problem hiding this comment.
I can see a lot of activity in Github org about nodejs 16 which is exciting!
@ethomson Is that list of blockers still up to date?
|
Hi @TingluoHuang |
|
@TingluoHuang Is there anything I can help with to get this merged? I can see there are some merge conflicts now? |
f161e76 to
b215abd
Compare
|
If you want extremely early feedback from a custom build, all works well for me apart from an upstream .NET issue: dotnet/runtime#64103, which looks like will be fixed in 6.0.5 (May) and has a workaround available. |
|
@ethomson This looks ready for another review I think? I've looked over it and it LGTM (though I'm not as familiar with codebase) |
b215abd to
4de0bde
Compare
4de0bde to
26b2719
Compare
26b2719 to
5e10633
Compare
| @@ -1,4 +1,5 @@ | |||
| using System; | |||
| #if !(OS_OSX && ARM64) | |||
There was a problem hiding this comment.
we don't have any osx-arm64 release publish yet, so all self-update L0 tests are failing because it can't find a package that matches the platform.
|
Awesome, now just waiting for a release, thanks! |
|
So what's the timeline to actually having m1 github actions now? :D |
|
@gabimoncha the runner package will be created in the release of this repo next Monday (🤞 ) for preview. You can configure your self-hosted macOS-arm64 runner after that. |
|
Please have a look on the build times This is the runner |
|
(Just wanted to chime in to say how excited I am for this to exist! It will be very very useful for us. Thank you to all who are working on it!) |
Create a runner package that is able to run on macOS M1.
https://github.com/github/c2c-actions-runtime/issues/1565
#805
Test summary:
runstep,node12actions, andnode16actions