Prefer node16 over node12 when running internal scripts#1621

Merged

fhammerl merged 28 commits intomainfrom

fhammerl/prefer-node16

Feb 14, 2022

Contributor

fhammerl commented Jan 21, 2022

Now that node 16 is supported, it should be used internally as well as encouraged in the docs.

fhammerl added 9 commits

January 20, 2022 15:11


          Use 16 to run RunnerService.js

af424b9


          Execute hashfiles using node16

cd22b4e


          Run downloadCert.js using node16

aaeecde


          Run makeWebRequest.js using node16

194bc7c


          Run macos-run-invoker.js using node16

5ce726c


          Run hashFiles.js using node16


          Update tests to use node16

bbca7b9


          Update documentation to recommend node16

22b07a3


          Duplicate macos service js fix for 16

c1433ee

fhammerl requested a review from a team as a code owner

January 21, 2022 10:14

thboop reviewed

View reviewed changes

src/Misc/layoutbin/update.sh.template Outdated Show resolved Hide resolved

thboop reviewed

View reviewed changes

src/Misc/layoutbin/update.sh.template Outdated Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

docs/adrs/0361-wrapper-action.md Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Test/L0/Worker/ActionManagerL0.cs Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Test/L0/Worker/ActionManifestManagerL0.cs Outdated Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Test/L0/Worker/StepHostL0.cs Outdated Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Test/TestData/nodeaction.yml Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Misc/layoutbin/runsvc.sh Show resolved Hide resolved

tavianator mentioned this pull request

Pipes appear to not pass on EOF on macOS runners #884

Open

fhammerl added 5 commits

January 24, 2022 14:42


          Add PR link

5b2b6b5


          Revert ADR node change

d88bd65


          Merge node12/16 retainment IFs

e6e313e


          Try both node12 and node16

155ca9e


          Close if

thboop reviewed

View reviewed changes

src/Misc/layoutbin/update.sh.template Outdated Show resolved Hide resolved

fhammerl added 5 commits

January 26, 2022 16:21


          Revert "Update tests to use node16"

76b2442

This reverts commit bbca7b9.


          Fix condition

98627f8


          Unfurl if condition

cc31a62


          Allow user to force a node version

90300da


          Format update template

df8aa7c

fhammerl commented

View reviewed changes

src/Misc/layoutbin/runsvc.sh Show resolved Hide resolved


          Comment env var

a5f9652

fhammerl commented

View reviewed changes

src/Runner.Common/Constants.cs Outdated Show resolved Hide resolved

This was referenced Feb 4, 2022

Updated project to run on node16 by default #1622

Closed

Create runner layout for osx-arm64 (Apple M1) platform. #1618

Merged

TingluoHuang reviewed

View reviewed changes

src/Runner.Common/Util/NodeUtil.cs Outdated Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Runner.Common/Util/NodeUtil.cs Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Runner.Common/Util/NodeUtil.cs Outdated Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Runner.Common/Util/NodeUtil.cs Outdated Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Runner.Common/Util/NodeUtil.cs Outdated Show resolved Hide resolved

fhammerl and others added 3 commits

February 7, 2022 13:29


          Rename vars

e99b8d0


          Fix naming


          Fix rename

68ac419

TingluoHuang reviewed

View reviewed changes

src/Runner.Common/Util/NodeUtil.cs Outdated Show resolved Hide resolved

TingluoHuang reviewed

View reviewed changes

src/Runner.Common/Util/NodeUtil.cs Show resolved Hide resolved

fhammerl added 5 commits

February 10, 2022 13:10


          Merge branch 'main' of https://github.com/actions/runner into fhammer…

4a2b976

…l/prefer-node16


          Set node ver override if job message has it

cc78578


          Merge branch 'fhammerl/prefer-node16' of https://github.com/actions/r…

93e5fe0

…unner into fhammerl/prefer-node16


          Format executionContext

3562a88


          Can only receive 'forceNode12' or nothing from FF

df7fb5b

No specific node version from server

TingluoHuang approved these changes

View reviewed changes

fhammerl merged commit bd77ccf into main

fhammerl deleted the fhammerl/prefer-node16 branch

February 14, 2022 14:06

TingluoHuang mentioned this pull request

Prefer node16 over node12 when running internal js script in runner #1590

Closed

lhunath mentioned this pull request

Add ARM + MacOS target to be able to use on self-hosted runners #805

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet