Update error to say 'uninstall' not 'unconfigure'#1179
Merged
TingluoHuang merged 2 commits intoactions:mainfrom Sep 1, 2021
Merged
Update error to say 'uninstall' not 'unconfigure'#1179TingluoHuang merged 2 commits intoactions:mainfrom
TingluoHuang merged 2 commits intoactions:mainfrom
Conversation
TingluoHuang
added a commit
that referenced
this pull request
Sep 1, 2021
* Temporary fix for macOS runner upgrade crash loop. (#1304) * Typo fixed (#1289) * Update error to say 'uninstall' not 'unconfigure' (#1179) * Update error to say 'uninstall' not 'unconfigure' * Say uninstall service in *nix config error msgs Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com> * Allow setting default severity to "notice" (#1213) * Show More Step Information in composite Actions (#1279) * Prepare 2.281.1 runner release. (#1305) Co-authored-by: Daniel Asztalos <asztalosdani@users.noreply.github.com> Co-authored-by: Nick Fields <50085412+nick-invision@users.noreply.github.com> Co-authored-by: Ferenc Hammerl <31069338+fhammerl@users.noreply.github.com> Co-authored-by: Vladimir Panteleev <CyberShadow@users.noreply.github.com> Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to
unconfigurea runner via./config.sh removeon an installed OSX service, the error currently readsUnconfigure service first(which is what removing the config technically is doing) but the user must run./svc.sh uninstallto uninstall the service before unconfiguring it. It's petty but the exception is unclear and a bit misleading, so update it to reflect the current action that must be taken before actually removing the configuration.