Skip to content

Allow all events to access cache #263

Merged
aiqiaoy merged 3 commits intomasterfrom
users/aiyan/allow-all-events
May 15, 2020
Merged

Allow all events to access cache #263
aiqiaoy merged 3 commits intomasterfrom
users/aiyan/allow-all-events

Conversation

@aiqiaoy
Copy link
Copy Markdown
Contributor

@aiqiaoy aiqiaoy commented Apr 17, 2020

This PR removes the check on the cache actions side and allows all events that are tied to a ref to access cache. It cannot be merged until after the server side change are fully rolled out.

Fixes: https://github.com/github/c2c-actions-service/issues/369

@aiqiaoy aiqiaoy changed the title Allow all events to access cache [Do not merge] [Do not merge] Allow all events to access cache Apr 17, 2020
@aiqiaoy aiqiaoy requested a review from joshmgross April 20, 2020 15:49
joshmgross
joshmgross approved these changes Apr 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's link this to the issues in this repo that are requesting additional event support.

@aiqiaoy aiqiaoy linked an issue Apr 20, 2020 that may be closed by this pull request
Allow using the cache for other than push and pull_request events #63
Closed
@manuyavuz-pointr
Copy link
Copy Markdown

manuyavuz-pointr commented Apr 21, 2020

Hello,

Can I ask if this is related to scoping problem that causes cache to be inaccessible for rerunning workflows from GitHub UI?

@aiqiaoy
Copy link
Copy Markdown
Contributor Author

aiqiaoy commented Apr 21, 2020

@manuyavuz-pointr No this is not related to the rerun scope issue.

#208 is the issue tracking the problem and the awesome @joshmgross wrote an explanation here #208 (comment).

@kristianfreeman
Copy link
Copy Markdown

kristianfreeman commented Apr 24, 2020

sorry for drive-by comment but just wanted to say i'm super excited for this 🎉

@joshmgross joshmgross mentioned this pull request May 4, 2020
Merged
@aiqiaoy aiqiaoy force-pushed the users/aiyan/allow-all-events branch from 565cb6e to 29b4783 Compare May 11, 2020 14:18
@aiqiaoy aiqiaoy changed the title [Do not merge] Allow all events to access cache Allow all events to access cache May 11, 2020
@smorimoto
Copy link
Copy Markdown
Contributor

smorimoto commented May 11, 2020

Looks good!

@aiqiaoy aiqiaoy merged commit 16a133d into master May 15, 2020
@localheinz
Copy link
Copy Markdown

localheinz commented May 16, 2020

Thanks a ton!

❤️ it!

@localheinz
Copy link
Copy Markdown

localheinz commented May 16, 2020 •
edited
Loading

@aiqiaoy

Just gave this a try, but it appears that the deployment event is still not supported:

Screen Shot 2020-05-16 at 14 17 02

What will it take to make actions/cache work with the deployment event?

A reference could be passed in the payload, for example (see https://developer.github.com/v3/repos/deployments/#create-a-deployment).

@kristenmills kristenmills mentioned this pull request May 16, 2020
Merged
@localheinz localheinz mentioned this pull request May 16, 2020
Closed
1 task
@localheinz
Copy link
Copy Markdown

localheinz commented May 17, 2020

Perhaps #317 will help?

@localheinz localheinz mentioned this pull request May 17, 2020
Open
@dentarg dentarg mentioned this pull request May 26, 2020
Merged
1 task
@aiqiaoy aiqiaoy deleted the users/aiyan/allow-all-events branch May 26, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@joshmgross joshmgross joshmgross approved these changes

@smorimoto smorimoto smorimoto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow using the cache for other than push and pull_request events

6 participants

@aiqiaoy @manuyavuz-pointr @kristianfreeman @smorimoto @localheinz @joshmgross