Enhancement: Allow usage when GITHUB_REF or ACTIONS_CACHE_REF are defined#317
Closed
localheinz wants to merge 1 commit intoactions:masterfrom
Closed
Enhancement: Allow usage when GITHUB_REF or ACTIONS_CACHE_REF are defined#317localheinz wants to merge 1 commit intoactions:masterfrom
localheinz wants to merge 1 commit intoactions:masterfrom
Conversation
d3e772c to
229896e
Compare
229896e to
f67cfd1
Compare
f67cfd1 to
77fd223
Compare
Contributor
|
👋 Thanks for your support @localheinz, please see my response on your other PR: #318 (comment) as to why this won't work and consider filing an issue for your use-case. |
Author
|
Thank you, @joshmgross! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
GITHUB_REFenvironment variable is not defined, butACTIONS_CACHE_REFFollows #263 (comment).
💁♂️ I would like to be able to use
actions/cachefordeploymentevents.Here's my use case:
deploymentin workflows, e.g., when pushing to a branch that should be deployed to a staging environment, or when pushing to a branch that should be deployed to a production environmentdeploymentevents in a separate workflow, where an application is deployed to an environment depending on thepayloadof thedeploymentevent, and here I would like to be able to useactions/cacheto speed up builds. Fordeploymentevents,GITHUB_REFis not defined.❓I'm wondering, the previously available
RefKeyis only used to verify whether the environment variableGITHUB_REFis defined, but as far as I could see, the actual value ofGITHUB_REFis never used. Why is that the case? Why do we care in the first place?