6cfa84: Change aria-hidden rule to focus on tabbable rather than focusable by tombrunet · Pull Request #1820 · act-rules/act-rules.github.io

tombrunet · 2022-03-24T17:39:21Z

Per Task Force discussions:
focusable, by spec, includes elements with tabindex="-1" because they can be programmatically focused, but also browsers allow them to be clickable and focused. The more significant issue is items that are tabbable within content that is aria-hidden.

Proposing a change in language that would focus on items that are tabbable.

Fixes #1807

Need for Call for Review:
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>

Pull Request Etiquette

When creating PR:

Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR.
Add label to indicate if it's a Rule, Definition or Chore.
Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

tombrunet · 2022-03-24T17:40:06Z

Update to Pass 4 is handled in #1819

_rules/aria-hidden-no-focusable-content-6cfa84.md

Jym77 · 2022-03-31T13:05:21Z

Also, I think this resolves #1807.
(you should add resolves #1807 to the initial description, so that the issue is automatically closed when the PR is merged: Linking a pull request to an issue).

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

tbostic32

We need a little wording change in the assumptions section to clean things up, otherwise I think this PR looks good. The issue @Jym77 brought up is something we should look at and probably deal with in a separate issue.

_rules/aria-hidden-no-focusable-content-6cfa84.md

Please look again

kengdoj

Just a question for line 51.

_rules/aria-hidden-no-focusable-content-6cfa84.md

HelenBurge

as per my comment - add a definition to [sequential focus navigation][]

…t-rules.github.io into hidden-not-tabbable

kengdoj

I also agree with @tbostic32 suggested change (on Apr 6).

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

Fix previously applied

tbostic32 · 2022-06-02T12:28:57Z

_rules/aria-hidden-no-focusable-content-6cfa84.md

 ## Assumptions

-Interacting with the page does not result in changing the `aria-hidden` [attribute value][] of target elements. An example of such a situation would be when closing a modal dialog makes previously hidden and not [focusable][] elements become [focusable][].
+Interacting with the page does not result in changing the `aria-hidden` [attribute value][] of target elements. An example of such a situation would be when closing a modal dialog makes previously hidden and elements not [focusable][] and part of the [sequential focus navigation][] become [focusable][] and part of the [sequential focus navigation][].


Suggested change

Interacting with the page does not result in changing the `aria-hidden` [attribute value][] of target elements. An example of such a situation would be when closing a modal dialog makes previously hidden and elements not [focusable][] and part of the [sequential focus navigation][] become [focusable][] and part of the [sequential focus navigation][].

Interacting with the page does not result in changing the `aria-hidden` [attribute value][] of target elements. An example of such a situation would be when closing a modal dialog makes previously hidden elements not [focusable][] and part of the [sequential focus navigation][] become [focusable][] and part of the [sequential focus navigation][].

tombrunet added 2 commits March 24, 2022 12:32

Change rule to focus on tabbale vs focusable

57ea05e

Move Fail 5 to Pass 5

d832f5a

tombrunet mentioned this pull request Mar 24, 2022

6cfa84: Modify pass example 4 to be more realistic, using a dialog #1819

Merged

7 tasks

Jym77 previously requested changes Mar 31, 2022

View reviewed changes

Jym77 requested a review from carlosapaduarte March 31, 2022 10:40

WilcoFiers requested review from WilcoFiers and tbostic32 March 31, 2022 13:09

tombrunet and others added 3 commits March 31, 2022 09:27

Update _rules/aria-hidden-no-focusable-content-6cfa84.md

a9898aa

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

Update expecation / assumptions

0d34250

Fix description

fab8cd8

Jym77 mentioned this pull request Apr 5, 2022

Keyboard trap "bumpers" cause aria-hidden has no focusable content rule false positive [6cfa84] #1824

Closed

tay1orjones mentioned this pull request Apr 6, 2022

[a11y]: Element "button" should not be focusable within the subtree of an element with an 'aria-hidden' attribute with value 'true' carbon-design-system/carbon#11095

Closed

2 tasks

tbostic32 previously requested changes Apr 7, 2022

View reviewed changes

_rules/aria-hidden-no-focusable-content-6cfa84.md Outdated Show resolved Hide resolved

Reword background statement about item vs tab reading

62bc44e

WilcoFiers approved these changes Apr 28, 2022

View reviewed changes

WilcoFiers requested review from HelenBurge and kengdoj April 28, 2022 13:32

kengdoj requested changes Apr 28, 2022

View reviewed changes

_rules/aria-hidden-no-focusable-content-6cfa84.md Outdated Show resolved Hide resolved

HelenBurge previously requested changes May 3, 2022

View reviewed changes

tombrunet added 5 commits May 5, 2022 13:44

Merge branch 'develop' into hidden-not-tabbable

b1e42f0

Fix definition

262d3b0

Merge branch 'hidden-not-tabbable' of https://github.com/tombrunet/ac…

0f412a0

…t-rules.github.io into hidden-not-tabbable

Adjust sentence regarding tabbable but hidden

aa6570c

Merge branch 'develop' into hidden-not-tabbable

c37f299

tombrunet requested review from HelenBurge and kengdoj May 27, 2022 13:38

kengdoj approved these changes Jun 1, 2022

View reviewed changes

tombrunet and others added 2 commits June 1, 2022 21:54

Update _rules/aria-hidden-no-focusable-content-6cfa84.md

1156222

Co-authored-by: Trevor R. Bostic <32486143+tbostic32@users.noreply.github.com>

Merge branch 'develop' into hidden-not-tabbable

965d9c2

HelenBurge approved these changes Jun 2, 2022

View reviewed changes

tbostic32 reviewed Jun 2, 2022

View reviewed changes

WilcoFiers added the Review Call 1 week Call for review for small changes label Jun 2, 2022

colabottles approved these changes Jun 3, 2022

View reviewed changes

Merge branch 'develop' into hidden-not-tabbable

d0aa6cf

WilcoFiers merged commit 19dc17f into act-rules:develop Jun 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

6cfa84: Change aria-hidden rule to focus on tabbable rather than focusable#1820

6cfa84: Change aria-hidden rule to focus on tabbable rather than focusable#1820
WilcoFiers merged 14 commits intoact-rules:developfrom
tombrunet:hidden-not-tabbable

tombrunet commented Mar 24, 2022 •

edited

Loading

Uh oh!

tombrunet commented Mar 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jym77 commented Mar 31, 2022 •

edited

Loading

Uh oh!

tbostic32 left a comment

Uh oh!

Uh oh!

kengdoj left a comment

Uh oh!

Uh oh!

HelenBurge left a comment

Uh oh!

kengdoj left a comment

Uh oh!

tbostic32 Jun 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	Interacting with the page does not result in changing the `aria-hidden` [attribute value][] of target elements. An example of such a situation would be when closing a modal dialog makes previously hidden and elements not [focusable][] and part of the [sequential focus navigation][] become [focusable][] and part of the [sequential focus navigation][].
	Interacting with the page does not result in changing the `aria-hidden` [attribute value][] of target elements. An example of such a situation would be when closing a modal dialog makes previously hidden elements not [focusable][] and part of the [sequential focus navigation][] become [focusable][] and part of the [sequential focus navigation][].

Conversation

tombrunet commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

Uh oh!

tombrunet commented Mar 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jym77 commented Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbostic32 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kengdoj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HelenBurge left a comment

Choose a reason for hiding this comment

Uh oh!

kengdoj left a comment

Choose a reason for hiding this comment

Uh oh!

tbostic32 Jun 2, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tombrunet commented Mar 24, 2022 •

edited

Loading

Jym77 commented Mar 31, 2022 •

edited

Loading