Skip to content

6cfa84: Modify pass example 4 to be more realistic, using a dialog#1819

Merged
WilcoFiers merged 19 commits intoact-rules:developfrom
tombrunet:hidden-dialog-sentinel
Jun 16, 2022
Merged

6cfa84: Modify pass example 4 to be more realistic, using a dialog#1819
WilcoFiers merged 19 commits intoact-rules:developfrom
tombrunet:hidden-dialog-sentinel

Conversation

@tombrunet
Copy link
Copy Markdown
Collaborator

@tombrunet tombrunet commented Mar 24, 2022

Per todays ACT Task Force call, modifying Pass 4 to use a dialog to better highlight why a focus sentinel might be used.

Need for Call for Review:
This will require a 1 week Call for Review (Testcase and description are essentially the same, but using more of a real world example as discussed on the call)

Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@tombrunet
Copy link
Copy Markdown
Collaborator Author

tombrunet commented Mar 24, 2022

@WilcoFiers Does this better match what you're expecting as more of a real world example? I don't recall if there were other changes requested.

@tombrunet
Copy link
Copy Markdown
Collaborator Author

tombrunet commented Mar 24, 2022

I'll open a separate PR regarding the focusable vs tabbable since that feels like an independent discussion.

@tombrunet
Copy link
Copy Markdown
Collaborator Author

tombrunet commented Mar 24, 2022

See also #1820

@tombrunet tombrunet mentioned this pull request Mar 24, 2022
Merged
7 tasks
WilcoFiers
WilcoFiers previously requested changes Mar 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a failed modal example as well that doesn't have the focus trap script?

@tombrunet
Copy link
Copy Markdown
Collaborator Author

tombrunet commented Mar 29, 2022

@WilcoFiers Added Fail 7 in Contrast to Pass 4. I couldn't think of a real world scenario for this other than the developer simply has a bug.

Jym77
Jym77 previously requested changes Mar 31, 2022
View reviewed changes
@Jym77
Copy link
Copy Markdown
Collaborator

Jym77 commented Mar 31, 2022

Looks like this resolves #1811. Can you add the link to the initial description?

@WilcoFiers WilcoFiers requested a review from tbostic32 March 31, 2022 13:09
@Jym77 Jym77 mentioned this pull request Mar 31, 2022
Closed
@tombrunet
Copy link
Copy Markdown
Collaborator Author

tombrunet commented Mar 31, 2022

Looks like this resolves #1811. Can you add the link to the initial description?

It felt like there is a two-part concern in #1811. I think this addresses the real-world example portion of it. I'm not sure this really addresses the difficulty in testing. If that's okay, I'll note that this fixes it.

@Jym77 Jym77 mentioned this pull request Apr 5, 2022
Closed
tbostic32
tbostic32 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tbostic32 tbostic32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could have discussions about the overall styling choices, but I think this is already an improvement as is.

@tombrunet
Copy link
Copy Markdown
Collaborator Author

tombrunet commented Apr 19, 2022

@WilcoFiers @Jym77 Adjusted Pass 4 / Fail 7 to be more descriptive. Let me know if that helps.

@WilcoFiers WilcoFiers dismissed stale reviews from Jym77 and themself April 21, 2022 13:14

Please look again

WilcoFiers
WilcoFiers reviewed Apr 28, 2022
View reviewed changes
@WilcoFiers WilcoFiers requested a review from HelenBurge April 28, 2022 13:32
@WilcoFiers WilcoFiers requested a review from kengdoj April 28, 2022 13:32
HelenBurge
HelenBurge requested changes May 3, 2022
View reviewed changes
@tombrunet tombrunet requested a review from HelenBurge May 5, 2022 18:42
@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Jun 2, 2022
@WilcoFiers WilcoFiers merged commit d86e2fe into act-rules:develop Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@colabottles colabottles colabottles approved these changes

@HelenBurge HelenBurge HelenBurge approved these changes

@Jym77 Jym77 Jym77 left review comments

@kengdoj kengdoj Awaiting requested review from kengdoj

+1 more reviewer

@tbostic32 tbostic32 tbostic32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Review Call 1 week Call for review for small changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tombrunet @Jym77 @WilcoFiers @tbostic32 @colabottles @HelenBurge