fix: stabilize cross-display drag snapback#310
Merged
acsandmann merged 1 commit intoacsandmann:mainfrom Mar 18, 2026
Merged
Conversation
Resolve window space from frame geometry before server-reported space to avoid stale-space snapback during cross-display drags. Also coalesce duplicate pending layout targets in animation/instant layout paths to reduce brief oscillation bursts.
There was a problem hiding this comment.
Pull request overview
Fixes rapid “snapback” oscillation when dragging windows across displays by improving space resolution and preventing redundant layout requests while a target frame is already pending.
Changes:
- Prefer geometry-based space classification before consulting the window-server-reported space.
- Skip redundant animated layout requests when the same target frame is already pending for a window.
- Skip redundant instant layout requests when the same target frame is already pending for a window.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/actor/reactor/animation.rs | Coalesces duplicate layout/instant-layout frame targets by skipping requests already pending in the transaction store. |
| src/actor/reactor.rs | Makes best_space_for_window geometry-first, falling back to window-server space only when geometry cannot resolve. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Owner
|
looks good, thanks for the pr |
acsandmann
added a commit
that referenced
this pull request
Mar 23, 2026
Resolve window space from frame geometry before server-reported space to avoid stale-space snapback during cross-display drags. Also coalesce duplicate pending layout targets in animation/instant layout paths to reduce brief oscillation bursts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an issue when dragging a window to an external screen, the window basically starts snapping back and forth very fast until I kill rift.
To fix it, I had to :