Skip to content

fix: add backpressure to it-merge#155

Merged
achingbrain merged 3 commits intomainfrom
fix/use-queueless-pushable
Mar 19, 2025
Merged

fix: add backpressure to it-merge#155
achingbrain merged 3 commits intomainfrom
fix/use-queueless-pushable

Conversation

@achingbrain
Copy link
Copy Markdown
Owner

To lower memory usage, use a queueless pushable for merging iterables.

This way we will only pull a new value from an iterable after the current value has been consumed instead of pulling from all of them as fast as possible.

To lower memory usage, use a queueless pushable for merging iterables.

This way we will only pull a new value from an iterable after the
current value has been consumed instead of pulling from all of them
as fast as possible.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.77%. Comparing base (66e2278) to head (6180ff3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/it-merge/test/index.spec.ts 88.46% 6 Missing ⚠️
packages/it-merge/src/index.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   96.82%   96.77%   -0.06%     
==========================================
  Files         107      107              
  Lines        9702     9753      +51     
  Branches     1457     1471      +14     
==========================================
+ Hits         9394     9438      +44     
- Misses        308      315       +7     
Flag Coverage Δ
chrome 97.03% <71.42%> (-0.04%) ⬇️
node 96.59% <86.44%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@achingbrain achingbrain merged commit eb49a35 into main Mar 19, 2025
@achingbrain achingbrain deleted the fix/use-queueless-pushable branch March 19, 2025 09:43
github-actions Bot pushed a commit that referenced this pull request Mar 19, 2025
## [it-merge-v3.0.8](it-merge-3.0.7...it-merge-3.0.8) (2025-03-19)

### Bug Fixes

* add backpressure to it-merge ([#155](#155)) ([eb49a35](eb49a35))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version it-merge-v3.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant