fix: unhanded promise rejection in it-byte-stream#130
Merged
achingbrain merged 1 commit intomainfrom May 30, 2024
Merged
Conversation
If no consumer is listening for the next value, and the underlying stream aborts, an unhandled promise rejection can occur. Instead, add a `.catch` listener so the UPR doesn't occur, the rejection will be processed next time a consumer tries to read a value.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 96.44% 96.41% -0.04%
==========================================
Files 98 98
Lines 9051 9054 +3
Branches 1343 1343
==========================================
Hits 8729 8729
- Misses 322 325 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version it-byte-stream-v1.0.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no consumer is listening for the next value, and the underlying stream aborts, an unhandled promise rejection can occur.
Instead, add a
.catchlistener so the UPR doesn't occur, the rejection will be processed next time a consumer tries to read a value.