fix: Memory leak with persistent task group#21
Merged
Conversation
* When a task group is used throughout the application's whole lifecycle, the prior implementation accumulates the references to completed tasks in its _tasks attribute. * Changing _tasks to a WeakSet resolves the issue.
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 65.09% 65.14% +0.04%
==========================================
Files 9 9
Lines 702 703 +1
==========================================
+ Hits 457 458 +1
Misses 245 245
Continue to review full report at Codecov.
|
achimnol
added a commit
to achimnol/edgedb-python
that referenced
this pull request
Dec 16, 2020
* Check out the added test cases in my derivation: achimnol/aiotools#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reported back to geldata/gel-python#140.