Skip to content

Allow projects composer deps management#8319

Closed
laemtl wants to merge 2 commits intoaces:mainfrom
laemtl:project-composer-deps
Closed

Allow projects composer deps management#8319
laemtl wants to merge 2 commits intoaces:mainfrom
laemtl:project-composer-deps

Conversation

@laemtl
Copy link
Copy Markdown
Contributor

@laemtl laemtl commented Jan 9, 2023 •
edited
Loading

  • Allow additional composer deps to be managed in project/ without the need to override the main composer.json.
  • Adds the documentation section to cover how to override LORIS.

To test:

  • create a project/composer.json with additional deps
  • run composer update

@laemtl laemtl force-pushed the project-composer-deps branch from 7910e0c to b946ee5 Compare January 9, 2023 18:11
jeffersoncasimir
jeffersoncasimir approved these changes Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Works as intended.

Comment thread docs/wiki/99_Developers/Code_Customization.md
**NOTE:** It is strongly not recommended to override LORIS library classes unless absolutely necessary. Overrides on libraries can cause upgrade issues and long term bugs and come at a great maintenance and overhead costs.*

***NOTE:** It is strongly not recommended to override LORIS library classes unless absolutely necessary. Overrides on libraries can cause upgrade issues and long term bugs and come at a great maintenance and overhead costs.*
Template stored under `project/templates/` will override the file of the same name found in the same path under `smarty/templates/`.
Copy link
Copy Markdown
Contributor

@jeffersoncasimir jeffersoncasimir Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Template stored under `project/templates/` will override the file of the same name found in the same path under `smarty/templates/`.
Templates stored under `project/templates/` will override the file of the same name found in the same path under `smarty/templates/`.

@jeffersoncasimir jeffersoncasimir added the Passed manual tests PR has been successfully tested by at least one peer label Feb 14, 2023
@laemtl laemtl closed this Mar 16, 2023
@regisoc regisoc mentioned this pull request Nov 21, 2024
Closed
This was referenced Nov 28, 2024
Closed
Merged
driusan pushed a commit that referenced this pull request Dec 5, 2024
@regisoc
[composer] manage project dependencies (#9496)
92c4d81 
- Allow additional composer deps to be managed in `project/` without the
need to override the main `composer.json`.
- Adds the documentation section to cover how to override LORIS.

Based on @laemtl's PR #8319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffersoncasimir jeffersoncasimir jeffersoncasimir approved these changes

Assignees

@driusan driusan

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laemtl @jeffersoncasimir @driusan