Skip to content

Add - Spike LR ATGM#8931

Merged
PabstMirror merged 29 commits intoacemod:masterfrom
TheCandianVendingMachine:spikeATGM
Jun 22, 2025
Merged

Add - Spike LR ATGM#8931
PabstMirror merged 29 commits intoacemod:masterfrom
TheCandianVendingMachine:spikeATGM

Conversation

@TheCandianVendingMachine
Copy link
Copy Markdown
Contributor

@TheCandianVendingMachine TheCandianVendingMachine commented Jun 3, 2022 •
edited
Loading

When merged this pull request will:

  • Adds Spike LR ATGM
  • Adds custom camera framework for Spike to use

Requires #10019

rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
rautamiekka
rautamiekka reviewed Jun 3, 2022
View reviewed changes
@TheCandianVendingMachine TheCandianVendingMachine changed the base branch from master to missile_guidance_rewrite May 28, 2024 03:35
@TheCandianVendingMachine TheCandianVendingMachine changed the title ADD - Missile Guidance - Spike LR ATGM Add - Spike LR ATGM May 28, 2024
@TheCandianVendingMachine TheCandianVendingMachine mentioned this pull request May 28, 2024
Merged
13 tasks
@TheCandianVendingMachine
Copy link
Copy Markdown
Contributor Author

TheCandianVendingMachine commented May 28, 2024

Updated to merge into new missile guidance branch

@PabstMirror PabstMirror deleted the branch acemod:master August 23, 2024 14:21
@PabstMirror
Copy link
Copy Markdown
Contributor

PabstMirror commented Aug 23, 2024

guess it auto closed because target merged, ugh

@PabstMirror
Copy link
Copy Markdown
Contributor

PabstMirror commented Aug 23, 2024

reopen test

@PabstMirror PabstMirror reopened this Aug 23, 2024
@PabstMirror PabstMirror changed the base branch from missile_guidance_rewrite to master August 23, 2024 14:42
PabstMirror and others added 8 commits August 23, 2024 09:44
@PabstMirror
Merge branch 'master' into pr/8931
7ceac89
@johnb432
Merge branch 'master' into pr/8931
576b814
@johnb432 @rautamiekka
Update addons/spike/functions/fnc_camera_switchAway.sqf
e25d240 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@johnb432 @rautamiekka
Update addons/spike/functions/fnc_camera_switchTo.sqf
78e9e6d 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@johnb432 @rautamiekka
Update addons/spike/functions/fnc_camera_update.sqf
fee64db 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@johnb432 @rautamiekka
Update addons/spike/functions/fnc_camera_update.sqf
a9e49d7 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@johnb432 @rautamiekka
Update addons/spike/functions/fnc_camera_updateTargetingGate.sqf
4d840a3 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@johnb432 @rautamiekka
Update addons/spike/functions/fnc_camera_userInCamera.sqf
b1e518e 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
johnb432
johnb432 requested changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All headers to camera functions (and some others) need to be updated with correct examples.

rautamiekka
rautamiekka suggested changes Aug 31, 2024
View reviewed changes
addons/spike/functions/fnc_keyDown.sqf
if ((currentWeapon ACE_player) != QGVAR(launcher)) exitWith {};

if (_key == SPIKE_KEY_DESIGNATE) then {
if (cameraView == "GUNNER") then {
Copy link
Copy Markdown
Contributor

@rautamiekka rautamiekka Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (cameraView == "GUNNER") then {
if (cameraView isEqualTo "GUNNER") then {

@PabstMirror PabstMirror added the kind/feature Release Notes: **ADDED:** label Feb 9, 2025
PabstMirror
PabstMirror reviewed Mar 10, 2025
View reviewed changes
PabstMirror
PabstMirror approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might be somethings that could be looked at

  • seems like missile sometimes runs out of thrust at end of flight
    Maybe cut data cable before it loses control-authority from lack of speed
  • can be tough to lock onto ground targets while in flight
    I'm not sure if real-life videos are at actual speed but it seems to be slower than in-game

but overall I'd much rather just get this merged and get feedback from more people

@PabstMirror PabstMirror added this to the 3.20.0 milestone May 9, 2025
PabstMirror and others added 4 commits May 25, 2025 09:37
@PabstMirror @rautamiekka
Update addons/spike/functions/fnc_camera_update.sqf
d903b0d 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@PabstMirror
update headers
e44e511
@PabstMirror @rautamiekka
Update addons/spike/functions/fnc_onFired.sqf
404c91a 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@PabstMirror @rautamiekka
Update addons/spike/functions/fnc_onFired.sqf
d4d4081 
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@PabstMirror PabstMirror requested a review from johnb432 June 10, 2025 14:51
johnb432
johnb432 reviewed Jun 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone have a test setup they are willing to share?

@PabstMirror @johnb432
key macros, sort prep, space headers
dd5e745 
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Apricot-ale added a commit to Apricot-ale/ACE3 that referenced this pull request Jun 19, 2025
@Apricot-ale
Spike LR acemod#8931 JP
65c4da7
PabstMirror added a commit that referenced this pull request Jun 19, 2025
@Apricot-ale @PabstMirror
Translations - Improve Japanese (3.20.0 part 3) (#10972)
fa97a2d 
* zeroin check jp

* Jp cycle word change

* Spike LR #8931 JP

* moving spike to it's pr

* sort

---------

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
johnb432
johnb432 approved these changes Jun 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the functionality, but code formatting looks good.

@PabstMirror PabstMirror merged commit 09a0e11 into acemod:master Jun 22, 2025
3 checks passed
@mrschick
Copy link
Copy Markdown
Contributor

mrschick commented Jun 28, 2025 •
edited
Loading

Got around to testing it a bit.
It seems really hard to lock onto distant targets (especially off-bore), mainly due to the digital inputs' high sensitivity.
Surely IRL it would have an analog input or a cumulative effect for the digital input. I could look into implementing the latter.

EDIT:
Zooming in thankfully makes slewing onto a target much easier.
Unfortunately there appear to be some guidance issues when engaging distant targets moving at high speed. The missile tries at all costs to overfly the target before flying down onto it, but if energy is insufficient to do so, it will stall out and miss, instead of falling back to a pure-pursuit and maintaining a max range glide attitude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@johnb432 johnb432 johnb432 approved these changes

+1 more reviewer

@rautamiekka rautamiekka rautamiekka requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/feature Release Notes: **ADDED:**

Projects

None yet

Milestone

3.20.0

Development

Successfully merging this pull request may close these issues.

5 participants

@TheCandianVendingMachine @PabstMirror @mrschick @rautamiekka @johnb432