Missileguidance - Minor code cleanup#11266
Merged
PabstMirror merged 4 commits intomisc-optimise-configPropertiesfrom Jan 30, 2026
Merged
Missileguidance - Minor code cleanup#11266PabstMirror merged 4 commits intomisc-optimise-configPropertiesfrom
PabstMirror merged 4 commits intomisc-optimise-configPropertiesfrom
Conversation
PabstMirror
reviewed
Jan 29, 2026
| TRACE_4("enabled",_shooter,_ammo,_projectile,typeOf _shooter); | ||
| TRACE_4("enabled",_shooter,typeOf _projectile,_projectile,typeOf _shooter); | ||
|
|
||
| private _config = configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON); |
Contributor
There was a problem hiding this comment.
clgp does some odd stuff and we need to keep the old way using _ammo
https://github.com/acemod/ACE3/blob/master/addons/missile_clgp/functions/fnc_submunition_ammoFired.sqf#L25-L28
calls this func with the first stage projectile but ammo set to the submunition (that actually gets the guidance)
PabstMirror
approved these changes
Jan 29, 2026
PabstMirror
pushed a commit
that referenced
this pull request
Feb 1, 2026
* Replace configProperties wherever possible * Update fnc_parseConfigForInjuries.sqf * Update fnc_cycleAttackProfileKeyDown.sqf * Update fnc_onFired.sqf * Revert count change * Update fnc_onFired.sqf * Missileguidance - Minor code cleanup (#11266) * Code cleanup * Revert _ammo changes * Update fnc_onFiredGetArgs.sqf * Revert some changes * Do cheaper check first * Add config command test cases * Use configClasses instead of configProperties wherever parent can't inherit subclasses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
configPropertieswherever possible #11265.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.