Compat Aegis - Add ace ballistics#11208
Merged
BrettMayson merged 7 commits intoacemod:masterfrom Jan 7, 2026
Merged
Conversation
johnb432
reviewed
Dec 31, 2025
Contributor
johnb432
left a comment
There was a problem hiding this comment.
This should be put into the main component, as it doesn't require ace_ballistics.
johnb432
reviewed
Jan 2, 2026
Contributor
johnb432
left a comment
There was a problem hiding this comment.
This isn't your doing, but the barrel length for the M110 is wrong. Therefore, it would be a good idea to go over all weapons with existing AB compatibility, to check if they are correct, but you don't have to - this PR is good as is.
johnb432
approved these changes
Jan 2, 2026
Contributor
johnb432
left a comment
There was a problem hiding this comment.
Just fixed the inheritance of the MP-153 classic and added the dependencies you had when it was in a separate addon, as they are still required.
Looks good to me, thanks for making the PR.
PabstMirror
approved these changes
Jan 7, 2026
BrettMayson
approved these changes
Jan 7, 2026
OverlordZorn
pushed a commit
to OverlordZorn/ACE3
that referenced
this pull request
Jan 11, 2026
* Compat Aegis - Add ace ballistics * Compat Aegis: shotguns smootbore * Compat Aegis - move ballistics to base of module * Compat Aegis - fix M4 shotgun * mp153 smoothbore and whitespace * Fix inheritance * Add missing dependencies --------- Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.