Fire - Add protection variable to uniforms#11113
Conversation
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
johnb432
left a comment
There was a problem hiding this comment.
Needs documentation, but LGTM otherwise.
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Wanted to wait in case there was suggested changes. Not really sure how the docs should be formatted. |
https://github.com/acemod/ACE3/blob/master/docs/wiki/framework/cargo-framework.md can be used as inspiration imo |
|
would this need a follow up PR to add the values to uniforms from 3rd party mods, for which ACE already provides compats (so mianly CUP/RHS/Vanilla) ? |
|
This PR doesn't modify any uniforms, if you want to do that go ahead |
| class CfgWeapons { | ||
| class yourUniformClass { | ||
| ace_fire_protection = 1; // 0-1 value for protection, intensity and incoming damage are scaled by (1 - _protection) | ||
| // 0 provides no protection, 1 provides full immunity to fire |
There was a problem hiding this comment.
add that 0 is the default if the entry is not present?
There was a problem hiding this comment.
Unnecessary imo, 0 is the default for any getNumber call
Update compat_ace_fire for ACE's new fire protection - acemod/ACE3#11113
When merged this pull request will:
1 - _protectionIMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.