Name Tags - Add variable to treat AI as players#10951
Merged
PabstMirror merged 3 commits intoacemod:masterfrom Jun 15, 2025
Merged
Name Tags - Add variable to treat AI as players#10951PabstMirror merged 3 commits intoacemod:masterfrom
PabstMirror merged 3 commits intoacemod:masterfrom
Conversation
Contributor
Author
|
Not sure if this same logic should be applied here on L55: if (_target != ACE_player &&
{(side group _target) == (side group ACE_player)} &&
{GVAR(showNamesForAI) || {[_target] call EFUNC(common,isPlayer)}} &&
{lineIntersectsSurfaces [_camPosASL, eyePos _target, ACE_player, _target] isEqualTo []} &&
{!isObjectHidden _target}) then {My use case was just for normal AI units, while this is for vehicle commanders |
PabstMirror
reviewed
Jun 10, 2025
PabstMirror
approved these changes
Jun 13, 2025
OverlordZorn
pushed a commit
to OverlordZorn/ACE3
that referenced
this pull request
Jun 16, 2025
* Add variable to treat AI as players * Rename variable * Add Pabst suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
GVAR(treatAsPlayer)variable to treat AI units as a player, including enemy AI.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.