GM Compat - Add CSW Compatability#10934
Merged
PabstMirror merged 7 commits intoacemod:masterfrom May 31, 2025
Merged
Conversation
This was referenced May 30, 2025
Contributor
Author
|
Looking for string table entries as well for this one. |
johnb432
reviewed
May 30, 2025
| disassembleWeapon = ""; // Carryable weapon created above | ||
| disassembleTurret = ""; // Which static tripod will appear when weapon is disassembled | ||
| disassembleTo = QGVAR(milan_backpack); // Abuse the tripods | ||
| magazineLocation = "[0.204429,0.696469,-0.680236]"; // Aseconds to load ammo into the weapon |
Contributor
There was a problem hiding this comment.
Comment doesn't match code.
Contributor
There was a problem hiding this comment.
I forgot to mention that this is the case pretty much everywhere these comments exist.
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
PabstMirror
reviewed
May 31, 2025
PabstMirror
reviewed
May 31, 2025
PabstMirror
reviewed
May 31, 2025
PabstMirror
reviewed
May 31, 2025
Contributor
|
nitpick, images are wrong aspect ratio, but can't really fix without copying and modifying their content |
OverlordZorn
pushed a commit
to OverlordZorn/ACE3
that referenced
this pull request
Jun 16, 2025
* initial commit * Removed extra files * removed extra include * Apply suggestions from code review Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Fixed comments and adjusted load/unload time for MILAN * Apply suggestions from code review * Fix `magazineLocation` comments --------- Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.