Skip to content

Vehicle Damage - Add Compatability for GM #10933

Merged
PabstMirror merged 3 commits intoacemod:masterfrom
lambdatiger:gmVehicleDamage
May 30, 2025
Merged

Vehicle Damage - Add Compatability for GM #10933
PabstMirror merged 3 commits intoacemod:masterfrom
lambdatiger:gmVehicleDamage

Conversation

@lambdatiger
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • This PR adds event handlers for GM's wheeled APCs. They don't inherit from Wheeled_APC_F and instead have their own parent class from Car_F.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't like hardcoding, but also can't think of a better way to get it done

@PabstMirror PabstMirror added this to the 3.20.0 milestone May 30, 2025
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label May 30, 2025
@lambdatiger
Copy link
Copy Markdown
Contributor Author

lambdatiger commented May 30, 2025

I don't like it either, another option is to make a function override in the GM compat for those two functions so at least it's contained to the compat addon.

@PabstMirror PabstMirror merged commit 380212f into acemod:master May 30, 2025
3 checks passed
OverlordZorn pushed a commit to OverlordZorn/ACE3 that referenced this pull request Jun 16, 2025
* add GM vehicle damage compat

* revert compat changes to split into another PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants