Cookoff - Add the ability to disable cookoff sounds and projectiles.#10926
Merged
PabstMirror merged 38 commits intoacemod:masterfrom Jun 4, 2025
Merged
Cookoff - Add the ability to disable cookoff sounds and projectiles.#10926PabstMirror merged 38 commits intoacemod:masterfrom
PabstMirror merged 38 commits intoacemod:masterfrom
Conversation
Contributor
Author
|
Untested by the way, I edited the entire thing on github's web editor (not even VS Code clone they have) |
DartRuffian
reviewed
May 24, 2025
addons/cookoff/XEH_postInit.sqf
Outdated
|
|
||
| if (hasInterface) then { | ||
| // If the sound is disabled, we exit. | ||
| if(!GVAR(cookoffDisableSound)) exitWith {}; |
Contributor
There was a problem hiding this comment.
Exiting here means changing the setting requires a mission restart
Contributor
Author
There was a problem hiding this comment.
Will update settings
Contributor
There was a problem hiding this comment.
Just don't exit there, so the setting can be changed mid-mission.
Member
There was a problem hiding this comment.
Just move this into L67 and you dont need any restarting
Peer reviewed the translation and suggested this change. Quote I mean you could say "Désactive le son de « pop-corn » des projectiles explosant à l'intérieur du véhicule" which is a tad more precise since "explosant dans le véhicule" could also be interpreted as incoming projectiles Endquote
jokoho48
reviewed
May 24, 2025
addons/cookoff/stringtable.xml
Outdated
| <Japanese>車両からの発射物の発射を無効にします</Japanese> | ||
| </Key> | ||
| <Key ID="STR_ACE_CookOff_disableSound_tooltip"> | ||
| <English>Disables the 'popcorn' sound of projectiles cooking off inside the vehicle</English> |
Member
There was a problem hiding this comment.
They are not popcorn sounds; they are the cookoff sounds of projectiles. I don't think Popcorn is the correct wording here.
Contributor
Author
There was a problem hiding this comment.
How about 'popping' sound / noise?
Contributor
Author
There was a problem hiding this comment.
How about 'popping' sound / noise?
disregard
Spanish, German, French and English are peer reviewed. **THE REST ARE NOT!**
Contributor
Author
|
Fixed @DartRuffian @jokoho48 - Restart no longer required and translation is more formal now. |
ilbinek
reviewed
May 24, 2025
ilbinek
reviewed
May 24, 2025
ilbinek
reviewed
May 24, 2025
ilbinek
reviewed
May 24, 2025
God AI is dogshit at its core functionality
johnb432
reviewed
May 25, 2025
Contributor
johnb432
left a comment
There was a problem hiding this comment.
You have inverted the settings logic everywhere:
if(!GVAR(cookoffDisableSound)) exitWith {};
Means so if the setting is disabled, nothing happens - which would be fine if the setting were an enable.
Either invert the logic everywhere or make it an enable setting, which imo is the safer and clearer option.
PabstMirror
reviewed
May 25, 2025
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Contributor
Author
|
Awesome sauce |
Member
|
Why are the features now disabled by default? i don't think it should be disabled by default because that is not how players are used to it. |
Contributor
Probably something that was forgotten when moving from a disable setting to an enable setting. |
johnb432
reviewed
May 29, 2025
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
PabstMirror
approved these changes
May 30, 2025
johnb432
requested changes
May 31, 2025
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
veteran29
previously requested changes
Jun 2, 2025
johnb432
approved these changes
Jun 2, 2025
LinkIsGrim
approved these changes
Jun 2, 2025
OverlordZorn
pushed a commit
to OverlordZorn/ACE3
that referenced
this pull request
Jun 16, 2025
…cemod#10926) * feat: add setting stringtable * Update initSettings.inc.sqf * Update stringtable.xml * Update initSettings.inc.sqf * Update XEH_postInit.sqf * Update fnc_detonateAmmunitionServerLoop.sqf * improve french translation Peer reviewed the translation and suggested this change. Quote I mean you could say "Désactive le son de « pop-corn » des projectiles explosant à l'intérieur du véhicule" which is a tad more precise since "explosant dans le véhicule" could also be interpreted as incoming projectiles Endquote * Make 'cookoffDisableSound' restart required. * update: move cookoffDisabledSound check to runtime * removed restart requirement from cookoffDisableSound * improve translation Spanish, German, French and English are peer reviewed. **THE REST ARE NOT!** * remove repeating bullshit * Update fnc_detonateAmmunitionServerLoop.sqf * remove dogshit translations, adde Czech by @ilbinek God AI is dogshit at its core functionality * remove typo * Update addons/cookoff/initSettings.inc.sqf Co-authored-by: PabstMirror <pabstmirror@gmail.com> * Update addons/cookoff/functions/fnc_detonateAmmunitionServerLoop.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/XEH_postInit.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/functions/fnc_detonateAmmunitionServerLoop.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/initSettings.inc.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * refactor: invert logic naming, remove outdated translations * Fix tabs * Update initSettings.inc.sqf * Fix stringtable file * Sort stringtable * Update addons/cookoff/initSettings.inc.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/initSettings.inc.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update fnc_detonateAmmunitionServerLoop.sqf * Update addons/cookoff/functions/fnc_detonateAmmunitionServerLoop.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/XEH_postInit.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/stringtable.xml Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/stringtable.xml Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Update addons/cookoff/stringtable.xml Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Use GVAR(cookoffEnableSound) setting --------- Co-authored-by: PabstMirror <pabstmirror@gmail.com> Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 2 checkbox options to cookoff
The following translations have been peer reviewed:
✅ Spanish
✅ French
✅ English
✅ Russian(Too sleepy to update, so outdated)AI generated translations were as dogshit as I imagined they'd be. Removed...