Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.

filter packages by the existence of a package.json file#575

Merged
istarkov merged 1 commit intoacdlite:masterfrom
spalger:fix/get-package-names
Dec 16, 2017
Merged

filter packages by the existence of a package.json file#575
istarkov merged 1 commit intoacdlite:masterfrom
spalger:fix/get-package-names

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Dec 16, 2017

Running yarn 1.0 in the recompose repo causes the installNestedPackageDeps script to run forever in a loop because it tries to run yarn in the src/packages/rx-recompose directory, which doesn't have a package.json file, which causes the dependencies to be installed in the root project, triggering the already executing postinstall script again and again.

If you'd prefer I can just remove the src/packages/rx-recompose directory, but perhaps there's a reason it's still there.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #575 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          49       49           
  Lines         370      370           
=======================================
  Hits          327      327           
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4745a0...7541b03. Read the comment docs.

@istarkov
Copy link
Copy Markdown
Contributor

Thank you!

@istarkov istarkov merged commit d7923b6 into acdlite:master Dec 16, 2017
neighborhood999 added a commit to neighborhood999/recompose that referenced this pull request Apr 22, 2018
* Add CHANGELOG.md

* add lifecycle example in docs

* filter packages by the existence of a package.json file (acdlite#575)

* use static class properties to convert toClass implicit return arrow

* Adding an optional callback argument to the `dispatch` method provided by `withReducer`

* Fix babel-plugin-lodash name on readme (acdlite#606)

* Add a debugging section in README

* Fix a typo in README

* Update docs & readme

* babel-preset-es2015 -> babel-preset-env

* change rest element to be the last in restructuring

* Pass blacklist argument to hoist-non-react-statics using hoistStatics

* Add blacklist docs for hoistStatics (acdlite#635)

* Refactor rollup config (acdlite#645)

- move all bundles into dist folder
- add size snapshot
- remove treeshake test

* Update dependencies before changes according to React 16.3+ (acdlite#646)

* New lifecycles support (acdlite#647)

* Remove cache from withHandlers

* Update createSink

* Update withPropsOnChange

* remove memoize as useless

* Simplify code

* Include flow types into library (acdlite#649)

* Fix types for modern flow

* Move flow declarations and test into recompose

* Fix docs

* Remove errors

* Add yarn-error to gitignore

* Append flow 2 test

* Update release to support flow types

* Remove unneeded command

* recompose v0.27.0

* chore: update yarn.lock

* chore: update yarn.lock

* fix: fix scripts

* fix: remove flow command in test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants